linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: fix clock framework on SH7757
Date: Fri, 07 May 2010 09:26:58 +0000	[thread overview]
Message-ID: <20100507092658.GB14009@linux-sh.org> (raw)
In-Reply-To: <4BE3DB68.1040503@renesas.com>

On Fri, May 07, 2010 at 06:20:40PM +0900, Yoshihiro Shimoda wrote:
>  - fix the recalc function's prototype
>  - This CPU don't have FRQCR
> 
Does it have FRQMR?

Does it support variable settings? If so, this just breaks it even
further since you're just limiting it to one arbitrary configuration.

You can look at the updated SH7785 and SH7786 clock frameworks for an
idea of how to deal with the FRQMR handling and MSTP-bits-as-clocks.

Any updates to existing subtypes in the clock framework should be moving
them over to the new interfaces, rather than perpetuating a hardcoded
pclk and divisors/multipliers for values that aren't fixed by the PLL.

  reply	other threads:[~2010-05-07  9:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07  9:20 [PATCH] sh: fix clock framework on SH7757 Yoshihiro Shimoda
2010-05-07  9:26 ` Paul Mundt [this message]
2010-05-07 10:06 ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100507092658.GB14009@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).