From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: modify pinmux for SH7757 2nd cut
Date: Fri, 07 May 2010 10:32:02 +0000 [thread overview]
Message-ID: <20100507103202.GG14009@linux-sh.org> (raw)
In-Reply-To: <4BE3DC84.4070203@renesas.com>
On Fri, May 07, 2010 at 07:15:31PM +0900, Yoshihiro Shimoda wrote:
> Paul Mundt wrote:
> > On Fri, May 07, 2010 at 06:25:24PM +0900, Yoshihiro Shimoda wrote:
> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >> ---
> >> arch/sh/include/cpu-sh4/cpu/sh7757.h | 301 +++---
> >> arch/sh/kernel/cpu/sh4a/pinmux-sh7757.c | 1582 ++++++++++++++++++-------------
> >> 2 files changed, 1081 insertions(+), 802 deletions(-)
> >>
> >> diff --git a/arch/sh/include/cpu-sh4/cpu/sh7757.h b/arch/sh/include/cpu-sh4/cpu/sh7757.h
> >> index f4d267e..15f3de1 100644
> >> --- a/arch/sh/include/cpu-sh4/cpu/sh7757.h
> >> +++ b/arch/sh/include/cpu-sh4/cpu/sh7757.h
> >> @@ -3,241 +3,252 @@
> >>
> >> enum {
> >> /* PTA */
> >> - GPIO_PTA7, GPIO_PTA6, GPIO_PTA5, GPIO_PTA4,
> >> - GPIO_PTA3, GPIO_PTA2, GPIO_PTA1, GPIO_PTA0,
> >> + GPIO_PTA0, GPIO_PTA1, GPIO_PTA2, GPIO_PTA3,
> >> + GPIO_PTA4, GPIO_PTA5, GPIO_PTA6, GPIO_PTA7,
> >>
> > This looks like the pinout has been completely inverted. Presumably if
> > this is added then support for the 1st cut will be completely broken?
> >
>
> Yes, I would like to remove the 1st cut supporting because it is prototype CPU.
>
We support many prototype CPUs upstream, so this is not an excuse. What
you are doing is effectively adding a new CPU and simply overloading a
previous one and screwing over anyone with one of those boards.
Even after your patches, the old CPU ID matching will still work, meaning
that anyone with one of those boards will have CPU_SH7757 set when it's
obvious that the second cut has absolutely nothing in common with the
first one.
If the first cut has never made it in to the wild, then I suppose that's
ok, but if there are already people externally that have these CPUs then
it's not acceptable to simply break the kernel underneath them on account
of the hardware people being unable to maintain consistency between
revisions.
If the 1st cut has already shipped, then the 2nd cut will have to be
added as a new CPU by itself. We managed to dodge this bullet for 7786 at
least by never supporting the 90nm version, but we would have obviously
been in the same situation there as well of adding a new CPU subtype to
account for the lack of consistency between silicon revisions.
next prev parent reply other threads:[~2010-05-07 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 9:25 [PATCH] sh: modify pinmux for SH7757 2nd cut Yoshihiro Shimoda
2010-05-07 9:29 ` Paul Mundt
2010-05-07 10:15 ` Yoshihiro Shimoda
2010-05-07 10:32 ` Paul Mundt [this message]
2010-05-07 11:24 ` Yoshihiro Shimoda
2010-05-07 11:34 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507103202.GG14009@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).