From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-shmobile: g3evm: Add IrDA support
Date: Thu, 20 May 2010 03:46:22 +0000 [thread overview]
Message-ID: <20100520034622.GH6661@linux-sh.org> (raw)
In-Reply-To: <ueihglic5.wl%kuninori.morimoto.gx@renesas.com>
On Thu, May 13, 2010 at 10:07:54AM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/board-g3evm.c | 33 +++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
>
It should be noted that sh_sir presently is only built for SH and not
ARCH_SHMOBILE. Adding ARCH_SHMOBILE blocks up on the asm/clock.h include
and shows that the driver itself is using deprecated clock lookups. While
none of this matters for the platform device data, you'll still need to
post a patch that tidies up the sh_sir driver and allows us to enable it
for the ARCH_SHMOBILE case.
next prev parent reply other threads:[~2010-05-20 3:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 1:07 [PATCH] ARM: mach-shmobile: g3evm: Add IrDA support Kuninori Morimoto
2010-05-20 3:15 ` Paul Mundt
2010-05-20 3:46 ` Paul Mundt [this message]
2010-05-21 1:27 ` Kuninori Morimoto
2010-05-21 1:30 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520034622.GH6661@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).