From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Date: Thu, 27 May 2010 19:55:44 +0000 Subject: [PATCH 0/2] blackfin: ptrace mm/sram_list fixes Message-Id: <20100527195544.GA25935@redhat.com> List-Id: References: <1274431345-22366-1-git-send-email-vapier@gentoo.org> <20100521162659.GA16193@redhat.com> <20100521183512.4477F40476@magilla.sf.frob.com> <20100522165320.GA19573@redhat.com> <25539.1274711817@redhat.com> <20100524151445.GA6393@redhat.com> <17134.1274778852@redhat.com> <20100525102345.GA23574@redhat.com> <20100526124006.GA28358@redhat.com> In-Reply-To: <20100526124006.GA28358@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mike Frysinger , Andrew Morton Cc: David Howells , Roland McGrath , linux-sh@vger.kernel.org, Paul Mundt , uclinux-dist-devel@blackfin.uclinux.org, linux-kernel@vger.kernel.org On 05/26, Oleg Nesterov wrote: > > On 05/25, Mike Frysinger wrote: > > > > we probably should add proper locking to this > > structure though. > > Agreed. I'll try to make the trivial patch tomorrow. I think we > can just use mm->mmap_sem, is_user_addr_valid() needs this lock > for find_vma() anyway. please see the patches. UNTESTED! the second one certainly needs the review from someone who knows what this code does ;) BTW. Obviously sys_sram_alloc() can create multiple sram_list_struct nodes with the same ->addr (with or without this patch), I hope this is fine. Oleg.