From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] sh_tmu: compute mult and shift before registration
Date: Wed, 02 Jun 2010 08:23:03 +0000 [thread overview]
Message-ID: <20100602082303.GB19079@linux-sh.org> (raw)
In-Reply-To: <1275342348-22499-1-git-send-email-aurelien@aurel32.net>
On Mon, May 31, 2010 at 11:45:48PM +0200, Aurelien Jarno wrote:
> Since commit 98962465ed9e6ea99c38e0af63fe1dcb5a79dc25 ("nohz: Prevent
> clocksource wrapping during idle"), the CPU of an R2D board never goes
> to idle. This commit assumes that mult and shift are assigned before
> the clocksource is registered. As a consequence the safe maximum sleep
> time is negative and the CPU never goes into idle.
>
> This patch fixes the problem by moving mult and shift initialization
> from sh_tmu_clocksource_enable() to sh_tmu_register_clocksource().
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Applied, thanks.
I've made a similar change for the sh_cmt driver, too.
Both of these should show up in the next 2.6.34-stable release.
next prev parent reply other threads:[~2010-06-02 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 21:45 [PATCH v2] sh_tmu: compute mult and shift before registration Aurelien Jarno
2010-06-02 8:23 ` Paul Mundt [this message]
2010-06-02 9:10 ` Aurelien Jarno
2010-06-07 7:06 ` Magnus Damm
2010-06-07 19:28 ` john stultz
2010-06-10 6:20 ` Magnus Damm
2010-06-10 19:27 ` john stultz
2010-06-11 3:03 ` john stultz
2010-06-11 4:38 ` Magnus Damm
2010-06-11 5:02 ` Magnus Damm
2010-06-11 6:01 ` Paul Mundt
2010-06-11 6:33 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602082303.GB19079@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox