From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-sh@vger.kernel.org
Subject: IORESOURCE_PCI_FIXED usage in pcibios_fixup_device_resources()
Date: Thu, 03 Jun 2010 22:38:32 +0000 [thread overview]
Message-ID: <201006031638.33726.bjorn.helgaas@hp.com> (raw)
The SH implementation of pcibios_fixup_device_resources() does the
equivalent of pcibios_bus_to_resource() for all the resources of a
device, except that it skips resources with the IORESOURCE_PCI_FIXED
flag set.
This looks like a bug to me. IORESOURCE_PCI_FIXED means the resource
cannot be moved, not that we should skip pcibios_bus_to_resource().
Does anybody know why pcibios_fixup_device_resources() does this check?
The only other IORESOURCE_PCI_FIXED reference I see in arch/sh is in
gapspci_fixup_resources(), so maybe it has something to do with that?
Bjorn
next reply other threads:[~2010-06-03 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 22:38 Bjorn Helgaas [this message]
2010-06-04 0:42 ` IORESOURCE_PCI_FIXED usage in pcibios_fixup_device_resources() Paul Mundt
2010-06-04 16:04 ` Bjorn Helgaas
2010-06-07 3:05 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006031638.33726.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox