From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Peter Huewe <PeterHuewe@gmx.de>
Cc: Mike Rapoport <mike@compulab.co.il>,
Wolfram Sang <w.sang@pengutronix.de>, Tejun Heo <tj@kernel.org>,
Ryan Mallon <ryan@bluewatersys.com>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
sfr@canb.auug.org.au,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] power: Rename get_current to fix build failure / name
Date: Mon, 14 Jun 2010 15:41:51 +0000 [thread overview]
Message-ID: <20100614154151.GA20343@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <201006141712.22248.PeterHuewe@gmx.de>
On Mon, Jun 14, 2010 at 05:12:22PM +0200, Peter Huewe wrote:
> Am Donnerstag 13 Mai 2010 07:27:28 schrieb Mike Rapoport:
> > Peter Huewe wrote:
> > > From: Peter Huewe <peterhuewe@gmx.de>
> > >
> > > This patch changes the name of get_current function pointer to
> > > get_battery_current to resolve a name conflict with the get_current
> > > macro defined in current.h.
> > >
> > > This conflict resulted in a build-failure[1] for the sh4 arch
> > > allyesconfig which is resolved by this patch.
> > >
> > > To be consistent the other function pointers (_voltage,_capacity) were
> > > renamed too.
> > >
> > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> > Acked-by: Ryan Mallon <ryan@bluewatersys.com>
> > Acked-by: Mike Rapoport <mike@compulab.co.il>
>
> Unfortunately this build-failure still exists, in Linux-next and hit Linus'
> Tree :/
>
> References:
> http://kisskb.ellerman.id.au/kisskb/buildresult/2709436/
> http://kisskb.ellerman.id.au/kisskb/buildresult/2687686/
Thanks for the patch.
As this is not a 2.6.35 regression, and only affects just
a few embedded platforms, I think this can wait for the next
merge window.
So, applied to battery-2.6.git (for -next).
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2010-06-14 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201005130154.58459.PeterHuewe@gmx.de>
[not found] ` <4BEB8DC0.4060808@compulab.co.il>
2010-06-14 15:12 ` [PATCH] power: Rename get_current to fix build failure / name conflict Peter Huewe
2010-06-14 15:41 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614154151.GA20343@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=PeterHuewe@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=ryan@bluewatersys.com \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).