* Re: [PATCH] power: Rename get_current to fix build failure / name conflict [not found] ` <4BEB8DC0.4060808@compulab.co.il> @ 2010-06-14 15:12 ` Peter Huewe 2010-06-14 15:41 ` [PATCH] power: Rename get_current to fix build failure / name Anton Vorontsov 0 siblings, 1 reply; 2+ messages in thread From: Peter Huewe @ 2010-06-14 15:12 UTC (permalink / raw) To: Mike Rapoport Cc: Anton Vorontsov, Wolfram Sang, Tejun Heo, Ryan Mallon, linux-kernel, linux-sh, sfr, Linus Torvalds Am Donnerstag 13 Mai 2010 07:27:28 schrieb Mike Rapoport: > Peter Huewe wrote: > > From: Peter Huewe <peterhuewe@gmx.de> > > > > This patch changes the name of get_current function pointer to > > get_battery_current to resolve a name conflict with the get_current > > macro defined in current.h. > > > > This conflict resulted in a build-failure[1] for the sh4 arch > > allyesconfig which is resolved by this patch. > > > > To be consistent the other function pointers (_voltage,_capacity) were > > renamed too. > > > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > Acked-by: Ryan Mallon <ryan@bluewatersys.com> > Acked-by: Mike Rapoport <mike@compulab.co.il> Unfortunately this build-failure still exists, in Linux-next and hit Linus' Tree :/ References: http://kisskb.ellerman.id.au/kisskb/buildresult/2709436/ http://kisskb.ellerman.id.au/kisskb/buildresult/2687686/ Thanks, Peter ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] power: Rename get_current to fix build failure / name 2010-06-14 15:12 ` [PATCH] power: Rename get_current to fix build failure / name conflict Peter Huewe @ 2010-06-14 15:41 ` Anton Vorontsov 0 siblings, 0 replies; 2+ messages in thread From: Anton Vorontsov @ 2010-06-14 15:41 UTC (permalink / raw) To: Peter Huewe Cc: Mike Rapoport, Wolfram Sang, Tejun Heo, Ryan Mallon, linux-kernel, linux-sh, sfr, Linus Torvalds On Mon, Jun 14, 2010 at 05:12:22PM +0200, Peter Huewe wrote: > Am Donnerstag 13 Mai 2010 07:27:28 schrieb Mike Rapoport: > > Peter Huewe wrote: > > > From: Peter Huewe <peterhuewe@gmx.de> > > > > > > This patch changes the name of get_current function pointer to > > > get_battery_current to resolve a name conflict with the get_current > > > macro defined in current.h. > > > > > > This conflict resulted in a build-failure[1] for the sh4 arch > > > allyesconfig which is resolved by this patch. > > > > > > To be consistent the other function pointers (_voltage,_capacity) were > > > renamed too. > > > > > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > > Acked-by: Ryan Mallon <ryan@bluewatersys.com> > > Acked-by: Mike Rapoport <mike@compulab.co.il> > > Unfortunately this build-failure still exists, in Linux-next and hit Linus' > Tree :/ > > References: > http://kisskb.ellerman.id.au/kisskb/buildresult/2709436/ > http://kisskb.ellerman.id.au/kisskb/buildresult/2687686/ Thanks for the patch. As this is not a 2.6.35 regression, and only affects just a few embedded platforms, I think this can wait for the next merge window. So, applied to battery-2.6.git (for -next). -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-14 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201005130154.58459.PeterHuewe@gmx.de>
[not found] ` <4BEB8DC0.4060808@compulab.co.il>
2010-06-14 15:12 ` [PATCH] power: Rename get_current to fix build failure / name conflict Peter Huewe
2010-06-14 15:41 ` [PATCH] power: Rename get_current to fix build failure / name Anton Vorontsov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).