From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Huewe <PeterHuewe@gmx.de>
Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org,
Kuninori Morimoto <morimoto.kuninori@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642
Date: Mon, 14 Jun 2010 16:10:34 +0000 [thread overview]
Message-ID: <20100614161034.GF14604@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <201006141739.42346.PeterHuewe@gmx.de>
On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote:
> bool "FSI-AK4642 sound support"
> depends on SND_SOC_SH4_FSI
> select SND_SOC_AK4642
> + select I2C
I'd have thought a depends was more appropriate. Arguably you want to
depend on the SH I2C driver since the driver is useless without the
relevant I2C controller.
next prev parent reply other threads:[~2010-06-14 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 15:39 [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642 Peter Huewe
2010-06-14 16:10 ` Mark Brown [this message]
2010-06-15 14:49 ` Peter Hüwe
2010-06-15 15:19 ` Mark Brown
2010-06-15 15:38 ` [PATCH v2] soc/sh: Fix I2C dependency for SND_FSI_AK4642 and SND_FSI_DA7210 Peter Huewe
2010-06-16 3:54 ` Paul Mundt
2010-06-16 7:43 ` Mark Brown
2010-06-16 7:49 ` Paul Mundt
2010-06-16 7:58 ` Mark Brown
2010-06-16 15:43 ` [PATCH v2] soc/sh: Fix I2C dependency for SND_FSI_AK4642 and Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614161034.GF14604@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=PeterHuewe@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=morimoto.kuninori@renesas.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).