From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH][RFC] ARM: mach-shmobile: AP4EVB: use gpio-leds for leds.
Date: Mon, 16 Aug 2010 04:23:28 +0000 [thread overview]
Message-ID: <20100816042328.GA8817@linux-sh.org> (raw)
In-Reply-To: <1281815121-3724-1-git-send-email-arnd@arndnet.de>
On Sat, Aug 14, 2010 at 09:45:21PM +0200, Arnd Hannemann wrote:
> This allows control of the leds on the AP4EVB board by kernel events (triggers)
> like mmc0/mmc1. In userland, the leds won't be available anymore over
> /sys/class/gpio but via /sys/class/leds.
>
> Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
A few minor nits. For starters, your editor has added trailing whitespace
all over the place, so please run future patches through checkpatch for
basic sanity checks first.
> +static struct gpio_led ap4evb_leds[] = {
[snip]
> +};
> +
> +static struct gpio_led_platform_data ap4evb_leds_pdata = {
> + .num_leds = ARRAY_SIZE(ap4evb_leds),
> + .leds = &ap4evb_leds,
> +};
> +
Here you obviously want .leds = ap4evb_leds. Has this been tested?
I'll apply it with those fixes, since it's a reasonable direction to go.
next prev parent reply other threads:[~2010-08-16 4:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 19:45 [PATCH][RFC] ARM: mach-shmobile: AP4EVB: use gpio-leds for leds Arnd Hannemann
2010-08-16 4:23 ` Paul Mundt [this message]
2010-08-16 6:59 ` Arnd Hannemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816042328.GA8817@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox