* [PATCH] sh: fix recursive dependency in Kconfig
@ 2010-08-14 12:23 Sam Ravnborg
2010-08-16 4:55 ` Paul Mundt
0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2010-08-14 12:23 UTC (permalink / raw)
To: linux-sh
When executing:
make ARCH=sh defconfig
kconfig segfaulted.
kconfig should obviously not segfault.
But this indicated a problem in the sh files which was
tracked down to a recursive dependency.
We select HAVE_HW_BREAKPOINT and in the following line
we use the same symbol in an expression.
Drop the conditional as it is of no use.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Marek <mmarek@suse.cz>
---
diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
index 33990fa..06645b6 100644
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -45,7 +45,7 @@ config SUPERH32
select HAVE_ARCH_KGDB
select HAVE_HW_BREAKPOINT
select HAVE_MIXED_BREAKPOINTS_REGS
- select PERF_EVENTS if HAVE_HW_BREAKPOINT
+ select PERF_EVENTS
select ARCH_HIBERNATION_POSSIBLE if MMU
config SUPERH64
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sh: fix recursive dependency in Kconfig
2010-08-14 12:23 [PATCH] sh: fix recursive dependency in Kconfig Sam Ravnborg
@ 2010-08-16 4:55 ` Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2010-08-16 4:55 UTC (permalink / raw)
To: linux-sh
On Sat, Aug 14, 2010 at 02:23:39PM +0200, Sam Ravnborg wrote:
> When executing:
>
> make ARCH=sh defconfig
>
> kconfig segfaulted.
> kconfig should obviously not segfault.
>
> But this indicated a problem in the sh files which was
> tracked down to a recursive dependency.
>
> We select HAVE_HW_BREAKPOINT and in the following line
> we use the same symbol in an expression.
> Drop the conditional as it is of no use.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Michal Marek <mmarek@suse.cz>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-16 4:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-14 12:23 [PATCH] sh: fix recursive dependency in Kconfig Sam Ravnborg
2010-08-16 4:55 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).