* [PATCH] initialise DMA engine before MMC
@ 2010-06-07 11:16 Guennadi Liakhovetski
2010-06-21 4:40 ` Paul Mundt
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2010-06-07 11:16 UTC (permalink / raw)
To: linux-kernel
Cc: linux-sh@vger.kernel.org, Dan Williams, Greg Kroah-Hartman,
linux-mmc
To use DMA engine based DMA with MMC in a non-modular build, the DMA
engine has to initialise before MMC.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
diff --git a/drivers/Makefile b/drivers/Makefile
index 91874e0..b713e75 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/
obj-y += lguest/
obj-$(CONFIG_CPU_FREQ) += cpufreq/
obj-$(CONFIG_CPU_IDLE) += cpuidle/
+obj-$(CONFIG_DMA_ENGINE) += dma/
obj-$(CONFIG_MMC) += mmc/
obj-$(CONFIG_MEMSTICK) += memstick/
obj-$(CONFIG_NEW_LEDS) += leds/
@@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/
obj-$(CONFIG_SUPERH) += sh/
obj-$(CONFIG_ARCH_SHMOBILE) += sh/
obj-$(CONFIG_GENERIC_TIME) += clocksource/
-obj-$(CONFIG_DMA_ENGINE) += dma/
obj-$(CONFIG_DCA) += dca/
obj-$(CONFIG_HID) += hid/
obj-$(CONFIG_PPC_PS3) += ps3/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] initialise DMA engine before MMC
2010-06-07 11:16 [PATCH] initialise DMA engine before MMC Guennadi Liakhovetski
@ 2010-06-21 4:40 ` Paul Mundt
2010-06-22 23:34 ` Dan Williams
2010-06-23 6:47 ` Linus Walleij
2010-08-27 19:49 ` [PATCH RESEND] " Chris Ball
2 siblings, 1 reply; 6+ messages in thread
From: Paul Mundt @ 2010-06-21 4:40 UTC (permalink / raw)
To: Guennadi Liakhovetski, Dan Williams
Cc: linux-kernel, linux-sh@vger.kernel.org, Greg Kroah-Hartman,
linux-mmc
On Mon, Jun 07, 2010 at 01:16:36PM +0200, Guennadi Liakhovetski wrote:
> To use DMA engine based DMA with MMC in a non-modular build, the DMA
> engine has to initialise before MMC.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Dan, any objections to this?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] initialise DMA engine before MMC
2010-06-21 4:40 ` Paul Mundt
@ 2010-06-22 23:34 ` Dan Williams
0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2010-06-22 23:34 UTC (permalink / raw)
To: Paul Mundt
Cc: Guennadi Liakhovetski, linux-kernel, linux-sh@vger.kernel.org,
Greg Kroah-Hartman, linux-mmc
On Sun, Jun 20, 2010 at 9:40 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> On Mon, Jun 07, 2010 at 01:16:36PM +0200, Guennadi Liakhovetski wrote:
>> To use DMA engine based DMA with MMC in a non-modular build, the DMA
>> engine has to initialise before MMC.
>>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> Dan, any objections to this?
No, objections, you can add my acked-by.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] initialise DMA engine before MMC
2010-06-07 11:16 [PATCH] initialise DMA engine before MMC Guennadi Liakhovetski
2010-06-21 4:40 ` Paul Mundt
@ 2010-06-23 6:47 ` Linus Walleij
2010-08-27 19:49 ` [PATCH RESEND] " Chris Ball
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2010-06-23 6:47 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: linux-kernel, linux-sh@vger.kernel.org, Dan Williams,
Greg Kroah-Hartman, linux-mmc
2010/6/7 Guennadi Liakhovetski <g.liakhovetski@gmx.de>:
> To use DMA engine based DMA with MMC in a non-modular build, the DMA
> engine has to initialise before MMC.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 91874e0..b713e75 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/
> obj-y += lguest/
> obj-$(CONFIG_CPU_FREQ) += cpufreq/
> obj-$(CONFIG_CPU_IDLE) += cpuidle/
> +obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_MMC) += mmc/
> obj-$(CONFIG_MEMSTICK) += memstick/
> obj-$(CONFIG_NEW_LEDS) += leds/
> @@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/
> obj-$(CONFIG_SUPERH) += sh/
> obj-$(CONFIG_ARCH_SHMOBILE) += sh/
> obj-$(CONFIG_GENERIC_TIME) += clocksource/
> -obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_DCA) += dca/
> obj-$(CONFIG_HID) += hid/
> obj-$(CONFIG_PPC_PS3) += ps3/
What I did was to move my DMA engines to subsystem_initcall(), with this
approach I would have had to rearrange a lot of subsystems I think.
But if it's easier for you this way by all means do it.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND] initialise DMA engine before MMC
2010-06-07 11:16 [PATCH] initialise DMA engine before MMC Guennadi Liakhovetski
2010-06-21 4:40 ` Paul Mundt
2010-06-23 6:47 ` Linus Walleij
@ 2010-08-27 19:49 ` Chris Ball
2010-08-27 20:02 ` Andrew Morton
2 siblings, 1 reply; 6+ messages in thread
From: Chris Ball @ 2010-08-27 19:49 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: akpm, linux-kernel, linux-sh@vger.kernel.org, Dan Williams,
Greg Kroah-Hartman, linux-mmc
Hi,
Andrew, mind taking this one?
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST)
To use DMA engine based DMA with MMC in a non-modular build, the DMA
engine has to initialise before MMC.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Dan Williams <dan.j.williams@intel.com>
---
diff --git a/drivers/Makefile b/drivers/Makefile
index 91874e0..b713e75 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/
obj-y += lguest/
obj-$(CONFIG_CPU_FREQ) += cpufreq/
obj-$(CONFIG_CPU_IDLE) += cpuidle/
+obj-$(CONFIG_DMA_ENGINE) += dma/
obj-$(CONFIG_MMC) += mmc/
obj-$(CONFIG_MEMSTICK) += memstick/
obj-$(CONFIG_NEW_LEDS) += leds/
@@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/
obj-$(CONFIG_SUPERH) += sh/
obj-$(CONFIG_ARCH_SHMOBILE) += sh/
obj-$(CONFIG_GENERIC_TIME) += clocksource/
-obj-$(CONFIG_DMA_ENGINE) += dma/
obj-$(CONFIG_DCA) += dca/
obj-$(CONFIG_HID) += hid/
obj-$(CONFIG_PPC_PS3) += ps3/
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] initialise DMA engine before MMC
2010-08-27 19:49 ` [PATCH RESEND] " Chris Ball
@ 2010-08-27 20:02 ` Andrew Morton
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2010-08-27 20:02 UTC (permalink / raw)
To: Chris Ball
Cc: Guennadi Liakhovetski, linux-kernel, linux-sh@vger.kernel.org,
Dan Williams, Greg Kroah-Hartman, linux-mmc
On Fri, 27 Aug 2010 20:49:39 +0100
Chris Ball <cjb@laptop.org> wrote:
> Hi,
>
> Andrew, mind taking this one?
>
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST)
>
> To use DMA engine based DMA with MMC in a non-modular build, the DMA
> engine has to initialise before MMC.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> ---
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 91874e0..b713e75 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/
> obj-y += lguest/
> obj-$(CONFIG_CPU_FREQ) += cpufreq/
> obj-$(CONFIG_CPU_IDLE) += cpuidle/
> +obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_MMC) += mmc/
> obj-$(CONFIG_MEMSTICK) += memstick/
> obj-$(CONFIG_NEW_LEDS) += leds/
> @@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/
> obj-$(CONFIG_SUPERH) += sh/
> obj-$(CONFIG_ARCH_SHMOBILE) += sh/
> obj-$(CONFIG_GENERIC_TIME) += clocksource/
> -obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_DCA) += dca/
> obj-$(CONFIG_HID) += hid/
> obj-$(CONFIG_PPC_PS3) += ps3/
erk, doing this via link ordering isn't nice.
It would be better to express this dependency via initcall levels -
core_initcall() or something.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-27 20:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-07 11:16 [PATCH] initialise DMA engine before MMC Guennadi Liakhovetski
2010-06-21 4:40 ` Paul Mundt
2010-06-22 23:34 ` Dan Williams
2010-06-23 6:47 ` Linus Walleij
2010-08-27 19:49 ` [PATCH RESEND] " Chris Ball
2010-08-27 20:02 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).