From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Remove unused __IGNORE_recvmmsg macro.
Date: Thu, 02 Sep 2010 06:13:13 +0000 [thread overview]
Message-ID: <20100902061312.GF10947@linux-sh.org> (raw)
In-Reply-To: <1283306055-761-1-git-send-email-carmelo.amoroso@st.com>
On Thu, Sep 02, 2010 at 06:29:11AM +0200, Carmelo AMOROSO wrote:
> Your patch wiring up the broken out syscalls does not wire up recvmmsg,
> so could you explain your reasoning for why you think this is unused?
>
> Paul,
> I've grep-ed across all the kernel source and I did not find any use of this macro.
> It is not relates to the sockecall at all.
>
The macro isn't, but the syscall is. recvmmsg is accessible through
socketcall, which is why we don't define it. Now that you have provided
broken out implementations to co-exist with the socketcall interface,
you'll want to wire up the recvmmsg syscall also (note that this is
different from recvmsg, which you already handle).
The IGNORE macros are there to tell the syscall checker that we don't
care about it, so not to warn during the build about the syscall being
unimplemented -- see scripts/checksyscalls.sh.
prev parent reply other threads:[~2010-09-02 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 1:54 [PATCH] sh: Remove unused __IGNORE_recvmmsg macro Carmelo AMOROSO
2010-09-02 2:54 ` Paul Mundt
2010-09-02 4:29 ` Carmelo AMOROSO
2010-09-02 6:13 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902061312.GF10947@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox