[PATCH] sh: Remove unused __IGNORE_recvmmsg macro.

[PATCH] sh: Remove unused __IGNORE_recvmmsg macro.

[Carmelo AMOROSO]

Signed-off-by: Carmelo Amoroso <carmelo.amoroso@st.com>
---
 arch/sh/include/asm/unistd_32.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/sh/include/asm/unistd_32.h b/arch/sh/include/asm/unistd_32.h
index a683d2f..4769278 100644
--- a/arch/sh/include/asm/unistd_32.h
+++ b/arch/sh/include/asm/unistd_32.h
@@ -372,8 +372,6 @@
 
 #ifdef __KERNEL__
 
-#define __IGNORE_recvmmsg
-
 #define __ARCH_WANT_IPC_PARSE_VERSION
 #define __ARCH_WANT_OLD_READDIR
 #define __ARCH_WANT_OLD_STAT
-- 
1.5.5.6

Re: [PATCH] sh: Remove unused __IGNORE_recvmmsg macro.

[Paul Mundt]

On Wed, Sep 01, 2010 at 03:54:15AM +0200, Carmelo AMOROSO wrote:
> Signed-off-by: Carmelo Amoroso <carmelo.amoroso@st.com>
> ---
>  arch/sh/include/asm/unistd_32.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/sh/include/asm/unistd_32.h b/arch/sh/include/asm/unistd_32.h
> index a683d2f..4769278 100644
> --- a/arch/sh/include/asm/unistd_32.h
> +++ b/arch/sh/include/asm/unistd_32.h
> @@ -372,8 +372,6 @@
>  
>  #ifdef __KERNEL__
>  
> -#define __IGNORE_recvmmsg
> -
>  #define __ARCH_WANT_IPC_PARSE_VERSION
>  #define __ARCH_WANT_OLD_READDIR
>  #define __ARCH_WANT_OLD_STAT

Your patch wiring up the broken out syscalls does not wire up recvmmsg,
so could you explain your reasoning for why you think this is unused?

RE: [PATCH] sh: Remove unused __IGNORE_recvmmsg macro.

[Carmelo AMOROSO]

-----Original Message-----
From: Paul Mundt [mailto:lethal@linux-sh.org] 
Sent: Thursday, September 02, 2010 4:54 AM
To: Carmelo AMOROSO
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Remove unused __IGNORE_recvmmsg macro.

On Wed, Sep 01, 2010 at 03:54:15AM +0200, Carmelo AMOROSO wrote:
> Signed-off-by: Carmelo Amoroso <carmelo.amoroso@st.com>
> ---
>  arch/sh/include/asm/unistd_32.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/sh/include/asm/unistd_32.h b/arch/sh/include/asm/unistd_32.h
> index a683d2f..4769278 100644
> --- a/arch/sh/include/asm/unistd_32.h
> +++ b/arch/sh/include/asm/unistd_32.h
> @@ -372,8 +372,6 @@
>  
>  #ifdef __KERNEL__
>  
> -#define __IGNORE_recvmmsg
> -
>  #define __ARCH_WANT_IPC_PARSE_VERSION
>  #define __ARCH_WANT_OLD_READDIR
>  #define __ARCH_WANT_OLD_STAT

Your patch wiring up the broken out syscalls does not wire up recvmmsg,
so could you explain your reasoning for why you think this is unused?

Paul,
I've grep-ed across all the kernel source and I did not find any use of this macro.
It is not relates to the sockecall at all.

Carmelo

Re: [PATCH] sh: Remove unused __IGNORE_recvmmsg macro.

[Paul Mundt]

On Thu, Sep 02, 2010 at 06:29:11AM +0200, Carmelo AMOROSO wrote:
> Your patch wiring up the broken out syscalls does not wire up recvmmsg,
> so could you explain your reasoning for why you think this is unused?
> 
> Paul,
> I've grep-ed across all the kernel source and I did not find any use of this macro.
> It is not relates to the sockecall at all.
> 
The macro isn't, but the syscall is. recvmmsg is accessible through
socketcall, which is why we don't define it. Now that you have provided
broken out implementations to co-exist with the socketcall interface,
you'll want to wire up the recvmmsg syscall also (note that this is
different from recvmsg, which you already handle).

The IGNORE macros are there to tell the syscall checker that we don't
care about it, so not to warn during the build about the syscall being
unimplemented -- see scripts/checksyscalls.sh.