From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Tue, 07 Sep 2010 09:40:48 +0000 Subject: Re: [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi sound support Message-Id: <20100907094047.GA7886@rakim.wolfsonmicro.main> List-Id: References: <20100906102557.GE10367@rakim.wolfsonmicro.main> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guennadi Liakhovetski Cc: Linux-ALSA , Paul Mundt , Liam Girdwood , Kuninori Morimoto , Linux-SH On Tue, Sep 07, 2010 at 09:11:28AM +0200, Guennadi Liakhovetski wrote: > On Mon, 6 Sep 2010, Mark Brown wrote: > > > > +static int sh_hdmi_snd_write(struct snd_soc_codec *codec, > > > Are these two actually needed? As long as you don't have a register cache > > > - no need for these? > > Something needs to translate the ASoC register I/O functions into what > > the HDMI layer code is expecting. > AFAICS, with ->reg_cache_size = 0 the ASoC core will not attempt to call > them. Could you please be more explicit here? Register I/O needs to happen somehow...