[PATCH] sh: ecovec24: modify tsc2007 platform settings

[PATCH] sh: ecovec24: modify tsc2007 platform settings

[Kuninori Morimoto]

This patch modify x_plate_ohms to correct value for tsc2007 panel,
and removed un-necessary ts_get_pendown_state()

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/sh/boards/mach-ecovec24/setup.c |   26 ++------------------------
 1 files changed, 2 insertions(+), 24 deletions(-)

diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
index 1d7b495..db7a7c0 100644
--- a/arch/sh/boards/mach-ecovec24/setup.c
+++ b/arch/sh/boards/mach-ecovec24/setup.c
@@ -400,32 +400,9 @@ static struct platform_device keysc_device = {
 
 /* TouchScreen */
 #define IRQ0 32
-static int ts_get_pendown_state(void)
-{
-	int val = 0;
-	gpio_free(GPIO_FN_INTC_IRQ0);
-	gpio_request(GPIO_PTZ0, NULL);
-	gpio_direction_input(GPIO_PTZ0);
-
-	val = gpio_get_value(GPIO_PTZ0);
-
-	gpio_free(GPIO_PTZ0);
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-
-	return val ? 0 : 1;
-}
-
-static int ts_init(void)
-{
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-	return 0;
-}
-
 static struct tsc2007_platform_data tsc2007_info = {
 	.model			= 2007,
-	.x_plate_ohms		= 180,
-	.get_pendown_state	= ts_get_pendown_state,
-	.init_platform_hw	= ts_init,
+	.x_plate_ohms		= 1000,
 };
 
 static struct i2c_board_info ts_i2c_clients = {
@@ -1119,6 +1096,7 @@ static int __init arch_setup(void)
 		gpio_direction_output(GPIO_PTF4, 1);
 
 		/* enable TouchScreen */
+		gpio_request(GPIO_FN_INTC_IRQ0, NULL);
 		i2c_register_board_info(0, &ts_i2c_clients, 1);
 		set_irq_type(IRQ0, IRQ_TYPE_LEVEL_LOW);
 	}
-- 
1.7.0.4

Re: [PATCH] sh: ecovec24: modify tsc2007 platform settings

[Paul Mundt]

On Fri, Aug 27, 2010 at 06:49:30PM +0900, Kuninori Morimoto wrote:
> This patch modify x_plate_ohms to correct value for tsc2007 panel,
> and removed un-necessary ts_get_pendown_state()
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Applied, thanks.

Re: [PATCH] sh: ecovec24: modify tsc2007 platform settings

[Kuninori Morimoto]

Dear Paul

> > This patch modify x_plate_ohms to correct value for tsc2007 panel,
> > and removed un-necessary ts_get_pendown_state()
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Applied, thanks.

Ohh Sorry Paul
This patch (and ARM: mach-shmobile: ap4evb: modify tsc2007 platform settings)
has same issue.
So, please revert it.

Best regards
--
Kuninori Morimoto
 

Re: [PATCH] sh: ecovec24: modify tsc2007 platform settings

[Paul Mundt]

On Tue, Sep 14, 2010 at 06:23:23PM +0900, Kuninori Morimoto wrote:
> 
> Dear Paul
> 
> > > This patch modify x_plate_ohms to correct value for tsc2007 panel,
> > > and removed un-necessary ts_get_pendown_state()
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Applied, thanks.
> 
> Ohh Sorry Paul
> This patch (and ARM: mach-shmobile: ap4evb: modify tsc2007 platform settings)
> has same issue.
> So, please revert it.
> 
Ok, I wasn't sure exactly what was going on. I had applied it in the ARM
case also, but then reverted it in order for

"ARM: mach-shmobile: ap4evb: modify touchpanel judgment condition"

to apply. However, I didn't see any similar patch for ecovec, so should
we just leave ecovec as it is?

Re: [PATCH] sh: ecovec24: modify tsc2007 platform settings

[Kuninori Morimoto]

Dear Paul

Thanks for your work

> Ok, I wasn't sure exactly what was going on. I had applied it in the ARM
> case also, but then reverted it in order for
> 
> "ARM: mach-shmobile: ap4evb: modify touchpanel judgment condition"
> 
> to apply. However, I didn't see any similar patch for ecovec, so should
> we just leave ecovec as it is?

Sorry about these stupid patches.

1) X  sh: ecovec24: modify tsc2007 platform settings
2) X  ARM: mach-shmobile: ap4evb: modify tsc2007 platform settings
3) O  ARM: mach-shmobile: ap4evb: modify touchpanel judgment condition

3) is bug fix patch for ap4evb board. -> this patch is needed.
1), 2) add new feature but had issue. -> these are new bug

Best regards
--
Kuninori Morimoto