From: Matt Fleming <matt@console-pimps.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>,
Paul Mundt <lethal@linux-sh.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend
Date: Mon, 27 Sep 2010 20:01:38 +0000 [thread overview]
Message-ID: <20100927200138.GG28588@console-pimps.org> (raw)
In-Reply-To: <20100916143254.GC13563@erda.amd.com>
On Thu, Sep 16, 2010 at 04:32:54PM +0200, Robert Richter wrote:
> > diff --git a/arch/sh/kernel/perf_event.c b/arch/sh/kernel/perf_event.c
> > index 2cb9ad5..3c3fc9a 100644
> > --- a/arch/sh/kernel/perf_event.c
> > +++ b/arch/sh/kernel/perf_event.c
> > @@ -59,6 +59,14 @@ static inline int sh_pmu_initialized(void)
> > return !!sh_pmu;
> > }
> >
> > +const char *sh_pmu_name(void)
> > +{
> > + if (!sh_pmu)
> > + return NULL;
> > +
> > + return sh_pmu->name;
> > +}
>
> Couldn't we make this a generic function like perf_num_counters()?
Well, ARM doesn't have names as strings for its pmus currently. What's
more, ARM wouldn't use it; SH would be the only user of this function. I
don't think this one makes sense to be a generic function.
next prev parent reply other threads:[~2010-09-27 20:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 6:07 [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-09-13 6:07 ` [PATCH 1/6] perf: Add helper function to return number of counters Matt Fleming
2010-09-16 12:32 ` [PATCH 1/6] perf: Add helper function to return number of Robert Richter
2010-09-13 6:07 ` [PATCH 2/6] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-09-16 12:46 ` Robert Richter
2010-09-13 6:07 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate init/exit functions Matt Fleming
2010-09-16 12:55 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate Robert Richter
2010-09-13 6:07 ` [PATCH 4/6] oprofile: Abstract the perf-events backend Matt Fleming
2010-09-16 13:15 ` Robert Richter
2010-09-13 6:07 ` [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-09-16 14:32 ` Robert Richter
2010-09-27 20:01 ` Matt Fleming [this message]
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:45 ` Robert Richter
2010-09-28 8:33 ` Matt Fleming
2010-09-30 1:04 ` Paul Mundt
2010-09-30 8:14 ` Will Deacon
[not found] ` <SNT125-W35B89F6AA83C8DD22E7946BA770@phx.gbl>
2010-09-13 7:50 ` [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 11:04 ` Matt Fleming
2010-09-13 10:08 ` Will Deacon
2010-09-13 11:18 ` Matt Fleming
2010-09-16 14:48 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927200138.GG28588@console-pimps.org \
--to=matt@console-pimps.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).