[PATCH] sh: fix uninitialized spinlock

[PATCH] sh: fix uninitialized spinlock

[Akinobu Mita]

The spinlock in traps_64.c is used without initialization.
This fixes it by declaring DEFINE_SPINLOCK() and makes the spinlock static
variable.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
---
 arch/sh/kernel/traps_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sh/kernel/traps_64.c b/arch/sh/kernel/traps_64.c
index e67e140..fda6355 100644
--- a/arch/sh/kernel/traps_64.c
+++ b/arch/sh/kernel/traps_64.c
@@ -50,7 +50,7 @@ asmlinkage void do_##name(unsigned long error_code, struct pt_regs *regs) \
 	do_unhandled_exception(trapnr, signr, str, __stringify(name), error_code, regs, current); \
 }
 
-spinlock_t die_lock;
+static DEFINE_SPINLOCK(die_lock);
 
 void die(const char * str, struct pt_regs * regs, long err)
 {
-- 
1.6.0.6

Re: [PATCH] sh: fix uninitialized spinlock

[Paul Mundt]

On Wed, Oct 06, 2010 at 12:54:00AM +0900, Akinobu Mita wrote:
> The spinlock in traps_64.c is used without initialization.
> This fixes it by declaring DEFINE_SPINLOCK() and makes the spinlock static
> variable.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: linux-sh@vger.kernel.org

Hmm, there was a reason why this was non-static before, but it seems like
whatever that was has since corrected itself.  Applied, thanks!