[PATCH] sh: fix an ms7724se compile breakage

[PATCH] sh: fix an ms7724se compile breakage

[Guennadi Liakhovetski]

Fix a compile breakage, caused by my own careless copy-paste.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c
index 3099c36..fe208d6 100644
--- a/arch/sh/boards/mach-se/7724/setup.c
+++ b/arch/sh/boards/mach-se/7724/setup.c
@@ -148,14 +148,14 @@ const static struct fb_videomode lcdc_720p_modes[] = {
 	{
 		.name		= "LB070WV1",
 		.sync		= 0, /* hsync and vsync are active low */
-		.xres		= 1280;
-		.yres		= 720;
-		.left_margin	= 220;
-		.right_margin	= 110;
-		.hsync_len	= 40;
-		.upper_margin	= 20;
-		.lower_margin	= 5;
-		.vsync_len	= 5;
+		.xres		= 1280,
+		.yres		= 720,
+		.left_margin	= 220,
+		.right_margin	= 110,
+		.hsync_len	= 40,
+		.upper_margin	= 20,
+		.lower_margin	= 5,
+		.vsync_len	= 5,
 	},
 };
 
@@ -163,14 +163,14 @@ const static struct fb_videomode lcdc_vga_modes[] = {
 	{
 		.name		= "LB070WV1",
 		.sync		= 0, /* hsync and vsync are active low */
-		.xres		= 640;
-		.yres		= 480;
-		.left_margin	= 105;
-		.right_margin	= 50;
-		.hsync_len	= 96;
-		.upper_margin	= 33;
-		.lower_margin	= 10;
-		.vsync_len	= 2;
+		.xres		= 640,
+		.yres		= 480,
+		.left_margin	= 105,
+		.right_margin	= 50,
+		.hsync_len	= 96,
+		.upper_margin	= 33,
+		.lower_margin	= 10,
+		.vsync_len	= 2,
 	},
 };
 

Re: [PATCH] sh: fix an ms7724se compile breakage

[Paul Mundt]

On Sun, Oct 03, 2010 at 06:24:42AM +0200, Guennadi Liakhovetski wrote:
> Fix a compile breakage, caused by my own careless copy-paste.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Hmm, I'm confused. This doesn't apply to my tree at present, so the
breakage at least was not introduced there. Is there some patch that this
is against that I've overlooked?

Re: [PATCH] sh: fix an ms7724se compile breakage

[Guennadi Liakhovetski]

On Wed, 6 Oct 2010, Paul Mundt wrote:

> On Sun, Oct 03, 2010 at 06:24:42AM +0200, Guennadi Liakhovetski wrote:
> > Fix a compile breakage, caused by my own careless copy-paste.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> 
> Hmm, I'm confused. This doesn't apply to my tree at present, so the
> breakage at least was not introduced there. Is there some patch that this
> is against that I've overlooked?

Strange, it's against next, and the patch, that introduces the breakage is 
http://marc.info/?l=linux-fbdev&m\x128349840517874&w=2 (44432407) and it's 
signed-off-by you, so, it went via one of your trees. Ah, I see, you 
pushed it via genesis.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

Re: [PATCH] sh: fix an ms7724se compile breakage

[Paul Mundt]

On Wed, Oct 06, 2010 at 10:13:13AM +0200, Guennadi Liakhovetski wrote:
> On Wed, 6 Oct 2010, Paul Mundt wrote:
> 
> > On Sun, Oct 03, 2010 at 06:24:42AM +0200, Guennadi Liakhovetski wrote:
> > > Fix a compile breakage, caused by my own careless copy-paste.
> > > 
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > 
> > Hmm, I'm confused. This doesn't apply to my tree at present, so the
> > breakage at least was not introduced there. Is there some patch that this
> > is against that I've overlooked?
> 
> Strange, it's against next, and the patch, that introduces the breakage is 
> http://marc.info/?l=linux-fbdev&m\x128349840517874&w=2 (44432407) and it's 
> signed-off-by you, so, it went via one of your trees. Ah, I see, you 
> pushed it via genesis.
> 
Aha. I'll apply it over there then, thanks.