From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Date: Wed, 06 Oct 2010 12:35:21 +0000 Subject: Re: [PATCH 1/7] perf: Add helper function to return number of Message-Id: <20101006123521.GM13563@erda.amd.com> List-Id: References: <20101006121410.GK13563@erda.amd.com> In-Reply-To: <20101006121410.GK13563@erda.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matt Fleming Cc: Peter Zijlstra , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Deng-Cheng Zhu , Grant Likely On 06.10.10 14:14:10, Robert Richter wrote: > On 04.10.10 16:44:19, Matt Fleming wrote: > > The number of counters for the registered pmu is needed in a few places > > so provide a helper function that returns this number. > > > > Signed-off-by: Matt Fleming > > Tested-by: Will Deacon > > --- > > arch/arm/kernel/perf_event.c | 6 ++++++ > > arch/arm/oprofile/common.c | 31 ++++++++++++++++++------------- > > arch/sh/kernel/perf_event.c | 9 +++++++++ > > include/linux/perf_event.h | 1 + > > 4 files changed, 34 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/oprofile/common.c b/arch/arm/oprofile/common.c > > index d660cb8..23f18a0 100644 > > --- a/arch/arm/oprofile/common.c > > +++ b/arch/arm/oprofile/common.c > > @@ -43,7 +43,7 @@ static DEFINE_MUTEX(op_arm_mutex); > > > > static struct op_counter_config *counter_config; > > static struct perf_event **perf_events[nr_cpumask_bits]; > > -static int perf_num_counters; > > +static int perf_nr_counters; Matt, as we will have one more version with this patch set, please use num_counters instead of perf_nr_counters. The same name is used also for x86. Thanks, -Robert > > > > /* > > * Overflow callback for oprofile. -- Advanced Micro Devices, Inc. Operating System Research Center