From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Date: Wed, 06 Oct 2010 19:45:07 +0000 Subject: Re: [PATCH 6/7] sh: oprofile: Use perf-events oprofile backend Message-Id: <20101006194507.GA30419@console-pimps.org> List-Id: References: <20101006183549.GW13563@erda.amd.com> In-Reply-To: <20101006183549.GW13563@erda.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robert Richter Cc: Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Deng-Cheng Zhu , Grant Likely On Wed, Oct 06, 2010 at 08:35:49PM +0200, Robert Richter wrote: > On 04.10.10 16:44:24, Matt Fleming wrote: > > Now that we've got a generic perf-events based oprofile backend we might > > as well make use of it seeing as SH doesn't do anything special with its > > oprofile backend. Also introduce a new CONFIG_HW_PERF_EVENTS symbol so > > that we can fallback to using the timer interrupt for oprofile if the > > CPU doesn't support perf events. > > > > Signed-off-by: Matt Fleming > > --- > > arch/sh/Kconfig | 13 +++++ > > arch/sh/oprofile/Makefile | 4 ++ > > arch/sh/oprofile/common.c | 109 ++++--------------------------------------- > > arch/sh/oprofile/op_impl.h | 33 ------------- > > 4 files changed, 28 insertions(+), 131 deletions(-) > > delete mode 100644 arch/sh/oprofile/op_impl.h > > This patch looks good. > > We might merge it with patch 7/7. This patch was broken out for Paul's benefit to ease review. If he's happy for me to merge this with 7/7 then that's fine with me.