From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support
Date: Fri, 15 Oct 2010 15:50:42 +0000 [thread overview]
Message-ID: <20101015155042.GA14975@linux-sh.org> (raw)
In-Reply-To: <w3pk4lk11gd.wl%kuninori.morimoto.gx@renesas.com>
On Fri, Oct 15, 2010 at 06:39:23PM +0900, Paul Mundt wrote:
> On Fri, Oct 15, 2010 at 03:42:55PM +0900, Kuninori Morimoto wrote:
> > So, the table size will be 8 x 65535 = 512K byte if FSIDIV have it.
> > (ex) div6 case is 8 x 64 = 512 byte
> > div4 case is 8 x 16 = 128 byte
> >
> > I thought 512K byte is too big for kernel.
> >
> Ok, that's certainly a valid reason. As we'll presumably see more of
> these in the future, how about something like this?
>
> +#define for_each_frequency(pos, r, freq) \
> + for (pos = r->min, freq = r->func(pos, r->arg); \
> + pos < r->max; pos++, freq = r->func(pos, r)) \
> + if (unlikely(freq = 0)) \
> + ; \
> + else
> +
Oops, the first r->arg needs to be changed to r or you'll blow up on the
table rounding. I've got all of these in my sh/clkfwk topic branch if you
simply wish to test that.
next prev parent reply other threads:[~2010-10-15 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 5:15 [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support Kuninori Morimoto
2010-10-15 6:16 ` Paul Mundt
2010-10-15 6:42 ` [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock Kuninori Morimoto
2010-10-15 9:39 ` [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support Paul Mundt
2010-10-15 15:50 ` Paul Mundt [this message]
2010-10-18 3:49 ` [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock Kuninori Morimoto
2010-10-18 8:56 ` [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support Paul Mundt
2010-10-18 10:10 ` [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock Kuninori Morimoto
2010-10-18 10:12 ` [PATCH 3/3] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015155042.GA14975@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).