Re: [PATCH] sh: i2c-sh7760: Replase from ctrl_* to __raw_*

Paul Mundt
2010-10-26T04:02:03Z

On Tue, Oct 26, 2010 at 09:08:12AM +0900, Nobuhiro Iwamatsu wrote:
> 2010/10/25 Ben Dooks <ben-i2c@fluff.org>:
> > On Mon, Oct 25, 2010 at 08:13:25PM +0900, Paul Mundt wrote:
> >> On Mon, Oct 25, 2010 at 11:47:18AM +0100, Ben Dooks wrote:
> >> > On Mon, Oct 25, 2010 at 10:58:35AM +0900, Paul Mundt wrote:
> >> > > On Sat, Oct 23, 2010 at 07:07:00AM +0900, Nobuhiro Iwamatsu wrote:
> >> > > > ctrl_* is deprecated. We should to use __raw_*.
> >> > > >
> >> > > > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> >> > >
> >> > > Applied, thanks.
> >> >
> >> > Hi, can you see my comments about the copy of this posted below
> >> > about ioremap() and use or __raw accessors?
> >> >
> >> No? At least it never made it to the list. Do you have a pointer handy?
> >
> > http://marc.info/?l=linux-i2c&m\x128797023230600&w=2
> >
>
> Sorry, this is my mistake.
>
> >> On Sun, Oct 24, 2010 at 05:37:46PM +0900, Nobuhiro Iwamatsu wrote:
> >> ctrl_* is deprecated. We should to use __raw_*.
> >
> >> Given iobase is ioremap() returned, there should be an explicit reason
> >> for using __raw_xxx() instead of read/writel().
>
Based on what, exactly? The CPU in question is quite content with the
weak ordering provided by __raw_xxx(), anything more is unecessary.