From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] SuperH on-chip EHCI glue
Date: Wed, 01 Dec 2010 07:02:15 +0000 [thread overview]
Message-ID: <20101201070215.GD19838@linux-sh.org> (raw)
In-Reply-To: <20101125080349.GG3270@linux-sh.org>
On Mon, Nov 29, 2010 at 10:49:58AM -0800, David Daney wrote:
> On 11/25/2010 12:03 AM, Paul Mundt wrote:
> [...]
> >diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> >index 67eb377..22a9173 100644
> >--- a/drivers/usb/Kconfig
> >+++ b/drivers/usb/Kconfig
> >@@ -66,6 +66,7 @@ config USB_ARCH_HAS_EHCI
> > default y if ARCH_AT91SAM9G45
> > default y if ARCH_MXC
> > default y if ARCH_OMAP3
> >+ default y if CPU_SUBTYPE_SH7786
> > default PCI
> >
>
> How about moving that to your archecture Kconfig as:
>
> ' select USB_ARCH_HAS_EHCI'
>
> We should be working towards reducing this per-chip churn in the Kconfig
> files if possible.
>
Good idea, I didn't realize other architectures were doing this already.
I've now ended up doing this for all of the SH subtypes with EHCI/OHCI
support, which will follow in an updated patch.
prev parent reply other threads:[~2010-12-01 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 8:03 [PATCH] SuperH on-chip EHCI glue Paul Mundt
2010-11-25 15:46 ` Alan Stern
2010-11-25 15:53 ` Paul Mundt
2010-11-25 16:10 ` Alan Stern
2010-11-29 18:49 ` David Daney
2010-12-01 7:02 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201070215.GD19838@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).