From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Date: Wed, 05 Jan 2011 19:42:09 +0000 Subject: Re: [PATCH] mmc: tmio_mmc: fix PIO fallback on DMA descriptor Message-Id: <20110105194209.GB9198@void.printf.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Ian Molton Hi Guennadi, On Thu, Nov 11, 2010 at 12:19:47PM +0100, Guennadi Liakhovetski wrote: > The easiest way to fall back to PIO, when a DMA descriptor allocation fails is > to disable DMA on the controller but continue with the current request in PIO > mode. This way tmio_mmc_start_dma() can become void, since it cannot be failing > any more. The current version is also broken: it is testing a wrong > pointer and thus failing to recognise, that a descriptor allocation wasn't > successful. > > Signed-off-by: Guennadi Liakhovetski Thanks, pushed to mmc-next for .38. I wrapped the commit message back to 72 chars, so that it doesn't overflow when running "git log" on an 80-char term. -- Chris Ball One Laptop Per Child