From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Date: Wed, 05 Jan 2011 19:50:16 +0000 Subject: Re: [PATCH 1/3] mmc: tmio: merge the private header into the driver Message-Id: <20110105195016.GC9198@void.printf.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Ian Molton , Samuel Ortiz On Tue, Nov 23, 2010 at 05:24:11PM +0100, Guennadi Liakhovetski wrote: > drivers/mmc/host/tmio_mmc.h is only used by drivers/mmc/host/tmio_mmc.c, this > needlessly complicates source-code handling. > > Signed-off-by: Guennadi Liakhovetski Ouch; but fixing it needlessly complicates patch handling, because now all future patches apply or don't based on whether they saw this patch. I think this decision should just be made once and lived with, without a stronger reason than this one to change it. I'll apply it since it's become a dependency now. Pushed to mmc-next. -- Chris Ball One Laptop Per Child