From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Date: Wed, 05 Jan 2011 20:57:17 +0000 Subject: Re: [PATCH 1/6 v3] mmc: tmio: implement SDIO IRQ Message-Id: <20110105205717.GG9198@void.printf.net> List-Id: References: <1293574956-30035-1-git-send-email-arnd@arndnet.de> <1293574956-30035-2-git-send-email-arnd@arndnet.de> In-Reply-To: <1293574956-30035-2-git-send-email-arnd@arndnet.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Hannemann Cc: linux-mmc@vger.kernel.org, Magnus Damm , linux-sh@vger.kernel.org, g.liakhovetski@gmx.de, Ian Molton , Samuel Ortiz Hi Arnd, On Tue, Dec 28, 2010 at 11:22:31PM +0100, Arnd Hannemann wrote: > This patch implements SDIO IRQ support for mfds which > announce the TMIO_MMC_SDIO_IRQ flag for tmio_mmc. > If MMC_CAP_SDIO_IRQ is also set SDIO IRQ signalling is activated. > Tested with a b43-based wireless SDIO card and sh_mobile_sdhi. > > Signed-off-by: Arnd Hannemann Thanks, pushed to mmc-next for .38 with minor 80-col changes below: diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index d74cdac..8d55b8a 100644 --- a/drivers/mmc/host/tmio_mmc.c +++ b/drivers/mmc/host/tmio_mmc.c @@ -298,8 +298,9 @@ static void tmio_mmc_clk_stop(struct tmio_mmc_host *host) /* * Testing on sh-mobile showed that SDIO IRQs are unmasked when - * CTL_CLK_AND_WAIT_CTL gets written, so we have to disable the device IRQ - * here and restore the SDIO IRQ mask before re-enabling the device IRQ. + * CTL_CLK_AND_WAIT_CTL gets written, so we have to disable the + * device IRQ here and restore the SDIO IRQ mask before + * re-enabling the device IRQ. */ if (pdata->flags & TMIO_MMC_SDIO_IRQ) disable_irq(host->irq); @@ -623,8 +624,9 @@ static irqreturn_t tmio_mmc_irq(int irq, void *devid) sd_ctrl_write16(host, CTL_SDIO_STATUS, sdio_status & ~TMIO_SDIO_MASK_ALL); if (sdio_ireg && !host->sdio_irq_enabled) { - pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! 0x%04x 0x%04x 0x%04x\n", - sdio_status, sdio_irq_mask, sdio_ireg); + pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! " + "0x%04x 0x%04x 0x%04x\n", + sdio_status, sdio_irq_mask, sdio_ireg); tmio_mmc_enable_sdio_irq(host->mmc, 0); goto out; } -- Chris Ball One Laptop Per Child