From: Chris Ball <cjb@laptop.org>
To: Arnd Hannemann <arnd@arndnet.de>
Cc: linux-mmc@vger.kernel.org, Ian Molton <ian@mnementh.co.uk>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] mmc: tmio: handle missing HW interrupts
Date: Wed, 05 Jan 2011 21:22:23 +0000 [thread overview]
Message-ID: <20110105212223.GJ9198@void.printf.net> (raw)
In-Reply-To: <1293628874-8140-2-git-send-email-arnd@arndnet.de>
Hi Arnd,
On Wed, Dec 29, 2010 at 02:21:13PM +0100, Arnd Hannemann wrote:
> This patch addresses this problem by introducing timeouts for outstanding
> interrupts. If a hardware interrupt is missing, a soft reset will be performed
> to bring the hardware back to a working state.
> Tested with the SDHI hardware block in sh7372 / AP4EVB.
>
> Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
This breaks compilation without CONFIG_TMIO_MMC_DMA=y, because it
attempts to compile tmio_mmc_reset_work() unconditionally even though
delayed_reset_work is only a member of tmio_mmc_host if TMIO_MMC_DMA=y:
drivers/mmc/host/tmio_mmc.c: In function ‘tmio_mmc_reset_work’:
drivers/mmc/host/tmio_mmc.c:357:31: error: ‘struct tmio_mmc_host’ has no member named ‘delayed_reset_work’
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-01-05 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 13:21 [PATCH 0/2 v2] mmc: tmio: handle missing HW interrupts Arnd Hannemann
2010-12-29 13:21 ` [PATCH 1/2 " Arnd Hannemann
2011-01-05 21:22 ` Chris Ball [this message]
2011-01-05 22:31 ` Arnd Hannemann
2011-01-05 22:44 ` Chris Ball
2010-12-29 13:21 ` [PATCH 2/2 v2] mmc: tmio: fix CMD irq handling Arnd Hannemann
2011-01-05 22:48 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105212223.GJ9198@void.printf.net \
--to=cjb@laptop.org \
--cc=arnd@arndnet.de \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).