From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Date: Wed, 05 Jan 2011 21:22:23 +0000 Subject: Re: [PATCH 1/2 v2] mmc: tmio: handle missing HW interrupts Message-Id: <20110105212223.GJ9198@void.printf.net> List-Id: References: <1293628874-8140-1-git-send-email-arnd@arndnet.de> <1293628874-8140-2-git-send-email-arnd@arndnet.de> In-Reply-To: <1293628874-8140-2-git-send-email-arnd@arndnet.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Arnd Hannemann Cc: linux-mmc@vger.kernel.org, Ian Molton , linux-sh@vger.kernel.org Hi Arnd, On Wed, Dec 29, 2010 at 02:21:13PM +0100, Arnd Hannemann wrote: > This patch addresses this problem by introducing timeouts for outstanding > interrupts. If a hardware interrupt is missing, a soft reset will be performed > to bring the hardware back to a working state. > Tested with the SDHI hardware block in sh7372 / AP4EVB. > > Signed-off-by: Arnd Hannemann This breaks compilation without CONFIG_TMIO_MMC_DMA=y, because it attempts to compile tmio_mmc_reset_work() unconditionally even though delayed_reset_work is only a member of tmio_mmc_host if TMIO_MMC_DMA=y: drivers/mmc/host/tmio_mmc.c: In function ‘tmio_mmc_reset_work’: drivers/mmc/host/tmio_mmc.c:357:31: error: ‘struct tmio_mmc_host’ has no member named ‘delayed_reset_work’ -- Chris Ball One Laptop Per Child