From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Arnd Hannemann <arnd@arndnet.de>,
linux-mmc@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, Ian Molton <ian@mnementh.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 1/6 v3] mmc: tmio: implement SDIO IRQ
Date: Wed, 05 Jan 2011 22:10:03 +0000 [thread overview]
Message-ID: <20110105221003.GL9198@void.printf.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1101052203090.5375@axis700.grange>
Hi Guennadi,
On Wed, Jan 05, 2011 at 10:09:42PM +0100, Guennadi Liakhovetski wrote:
> > - pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! 0x%04x 0x%04x 0x%04x\n",
> > - sdio_status, sdio_irq_mask, sdio_ireg);
> > + pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! "
> > + "0x%04x 0x%04x 0x%04x\n",
> > + sdio_status, sdio_irq_mask, sdio_ireg);
>
> Don't think this is a good idea. 80-columns restriction stopped being a
> requirement since some time, and - it has always been explicitly requested
> _not_ to break strings in prints because of this. Yes, it is not very
> likely, that someone will grep for "IRQ.*\%" or similar, still, I would
> prefer to keep the original version.
Okay, I'll use the original version of the pr_warning().
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-01-05 22:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 22:22 [PATCH 0/6 v3] mmc: tmio: Add SDIO IRQ support Arnd Hannemann
2010-12-28 22:22 ` [PATCH 1/6 v3] mmc: tmio: implement SDIO IRQ Arnd Hannemann
2011-01-05 20:57 ` Chris Ball
2011-01-05 21:09 ` Guennadi Liakhovetski
2011-01-05 22:10 ` Chris Ball [this message]
2010-12-28 22:22 ` [PATCH 2/6 v3] mfd: sh_mobile_sdhi: activate SDIO IRQ for tmio_mmc Arnd Hannemann
2011-01-05 20:58 ` [PATCH 2/6 v3] mfd: sh_mobile_sdhi: activate SDIO IRQ for Chris Ball
2010-12-28 22:22 ` [PATCH 3/6 v3] ARM: mach-shmobile: sh7372 Enable SDIO IRQs Arnd Hannemann
2011-01-06 4:11 ` Paul Mundt
2010-12-28 22:22 ` [PATCH 4/6 v3] sh: sh7724 " Arnd Hannemann
2011-01-06 4:12 ` Paul Mundt
2010-12-28 22:22 ` [PATCH 5/6 v3] sh: sh7722 " Arnd Hannemann
2010-12-28 22:22 ` [PATCH 6/6 v3] sh: sh7723 / ap325rxa enable " Arnd Hannemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105221003.GL9198@void.printf.net \
--to=cjb@laptop.org \
--cc=arnd@arndnet.de \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).