From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] mmc, sh: Move MMCIF_PROGRESS_* into sh_mmcif.h
Date: Fri, 14 Jan 2011 07:08:16 +0000 [thread overview]
Message-ID: <20110114070815.GB2122@linux-sh.org> (raw)
In-Reply-To: <20110110230549.GA20886@verge.net.au>
On Fri, Jan 14, 2011 at 04:06:55PM +0900, Magnus Damm wrote:
> On Fri, Jan 14, 2011 at 10:29 AM, Simon Horman <horms@verge.net.au> wrote:
> > Drat. There seems to be a new problem.
> > I'm pretty sure it wasn't there when I checked against
> > Linus's tree a few days ago. But in any case it is there now.
> >
> > arch/arm/boot/compressed/mmcif-sh7372.o: In function `mmcif_loader':
> > mmcif-sh7372.c:(.text+0x9e8): undefined reference to `outer_cache
> >
> > As per
> > http://www.arm.linux.org.uk/developer/patches/viewpatch.php?idb75/1,
> > my suggested fix is:
> >
> > diff --git a/include/linux/mmc/sh_mmcif.h b/include/linux/mmc/sh_mmcif.h
> > index bf17350..1a6eb3f 100644
> > --- a/include/linux/mmc/sh_mmcif.h
> > +++ b/include/linux/mmc/sh_mmcif.h
> > @@ -99,7 +99,7 @@ static inline u32 sh_mmcif_readl(void __iomem *addr, int reg)
> >
> > ?static inline void sh_mmcif_writel(void __iomem *addr, int reg, u32 val)
> > ?{
> > - ? ? ? writel(val, addr + reg);
> > + ? ? ? __raw_writel(val, addr + reg);
> > ?}
>
> You probably want to update sh_mmcif_read() as well for code consistency!
>
I've already taken care of it.
prev parent reply other threads:[~2011-01-14 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 23:05 [PATCH] mmc, sh: Move MMCIF_PROGRESS_* into sh_mmcif.h Simon Horman
2011-01-11 2:07 ` Paul Mundt
2011-01-11 2:51 ` Simon Horman
2011-01-11 3:51 ` Simon Horman
2011-01-13 21:12 ` Paul Mundt
2011-01-14 1:29 ` Simon Horman
2011-01-14 6:49 ` Paul Mundt
2011-01-14 7:06 ` Magnus Damm
2011-01-14 7:08 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114070815.GB2122@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).