From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] [rfc] ARM: mach-shmobile: mackerel: clarify shdi/mmcif
Date: Wed, 19 Jan 2011 00:32:08 +0000 [thread overview]
Message-ID: <20110119003208.GA15192@verge.net.au> (raw)
In-Reply-To: <1291849274-8115-1-git-send-email-horms@verge.net.au>
Hi Goda-san,
On Tue, Jan 11, 2011 at 04:30:38PM +0900, Yusuke Goda wrote:
> Hi Simon-san
>
> (2011/01/08 7:26), Simon Horman wrote:
> > * Pins 2 and 4 of switch 33 are documented as don't care on the PCB,
> > my testing seems to confirm this.
> I approve of your patch.
Great. Can I take that to mean that Paul can merge this change?
> Pins 2 and 4 of switch 33 dont' care in mackerel.
> There was a mistake in the Users Manual.
> I asked a designer to revise Users Manual.
> Thank you for your indication.
>
> > * I have been unable to do anything sensible with S1 set to on.
> > Am I missing something with regards to MMC1?
> SW1 ON : Can not use MCP(NOR, NAND) and Ether
> Therefore, u-boot does not start.
>
> > * Clarify which driver is needed for each switch setting.
> >
> > * Should the AP4 board code be updated to allow the
> > SHDI driver to access SHDI1 as the mackerel code does?
> In AP4, pins 2 and 4 of switch 33 should care.
>
> Thanks,
> Goda
>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> > ---
> > arch/arm/mach-shmobile/board-mackerel.c | 5 ++---
> > 1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> > index 42f7c0d..b190248 100644
> > --- a/arch/arm/mach-shmobile/board-mackerel.c
> > +++ b/arch/arm/mach-shmobile/board-mackerel.c
> > @@ -167,9 +167,8 @@
> > * SW1 | SW33
> > * | bit1 | bit2 | bit3 | bit4
> > * -------------+------+------+------+-------
> > - * MMC0 OFF | OFF | ON | ON | X
> > - * MMC1 ON | OFF | ON | X | ON
> > - * SDHI1 OFF | ON | X | OFF | ON
> > + * MMC0 OFF | OFF | X | ON | X (Use MMCIF)
> > + * SDHI1 OFF | ON | X | OFF | X (Use MFD_SH_MOBILE_SDHI)
> > *
> > */
> >
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-01-19 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 23:01 [PATCH] [rfc] ARM: mach-shmobile: mackerel: Add zboot support Simon Horman
2011-01-07 22:26 ` [PATCH] [rfc] ARM: mach-shmobile: mackerel: clarify shdi/mmcif switch settings Simon Horman
2011-01-11 7:30 ` [PATCH] [rfc] ARM: mach-shmobile: mackerel: clarify shdi/mmcif Yusuke Goda
2011-01-19 0:32 ` Simon Horman [this message]
2011-01-19 0:46 ` [PATCH] [rfc] ARM: mach-shmobile: mackerel: clarify shdi/mmcif switch settings Paul Mundt
2011-01-19 0:47 ` [PATCH] [rfc] ARM: mach-shmobile: mackerel: clarify shdi/mmcif Yusuke Goda
2011-01-19 1:09 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119003208.GA15192@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).