From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: build error in ehci-hcd when disable PCI bus
Date: Wed, 02 Feb 2011 23:36:02 +0000 [thread overview]
Message-ID: <20110202233602.GA11610@linux-sh.org> (raw)
In-Reply-To: <4D48D301.9080705@renesas.com>
On Wed, Feb 02, 2011 at 12:44:01PM +0900, Yoshihiro Shimoda wrote:
> I found the build error when I am debugging other board.
> Also I can duplicate this issue on sdk7786 when the PCI bus is disabled.
> I tested linux-2.6.38-rc3.
> Do you think what souce code should I fix?
>
> ******* build Log *******
> In file included from drivers/usb/host/ehci-hcd.c:340:
> drivers/usb/host/ehci-sched.c: In function ?ehci_quirk_amd_L1?:
> drivers/usb/host/ehci-sched.c:1606: error: implicit declaration of function ?outb_p?
> drivers/usb/host/ehci-sched.c:1607: error: implicit declaration of function ?inb_p?
> drivers/usb/host/ehci-sched.c:1611: error: implicit declaration of function ?outl_p?
> drivers/usb/host/ehci-sched.c:1614: error: implicit declaration of function ?inl_p?
> make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
> **************************
>
When the PCI bus is disabled we don't really have any concept of PIO, so
PIO support and the associated accessors are explicitly disabled.
The quirk this refers to looks like it may depend on PCI, and if not, it
certainly has a platform dependency that can be used to encapsulate it.
The proper fix here is to fix ehci-sched.c, not re-introduce broken PIO
crap that wraps in to MMIO.
next prev parent reply other threads:[~2011-02-02 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 3:44 build error in ehci-hcd when disable PCI bus Yoshihiro Shimoda
2011-02-02 4:39 ` Nobuhiro Iwamatsu
2011-02-02 23:36 ` Paul Mundt [this message]
2011-02-02 23:44 ` Nobuhiro Iwamatsu
2011-02-02 23:46 ` Nobuhiro Iwamatsu
2011-02-03 1:29 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202233602.GA11610@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).