From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: prevent setup of uninitialized serial console
Date: Wed, 09 Feb 2011 07:28:22 +0000 [thread overview]
Message-ID: <20110209072822.GB16518@linux-sh.org> (raw)
In-Reply-To: <1297221526-32283-1-git-send-email-gnurou@gmail.com>
On Wed, Feb 09, 2011 at 12:18:46PM +0900, Alexandre Courbot wrote:
> Commit 906b17dc089f7fa87e37a9cfe6ee185efc90e0da introduced a condition
> where the kernel will crash unless a earlyprintk parameter is specified.
>
> Without this parameter, sci_console_init is called during early console
> setup without any port being initialized, and the kernel crashes a
> little bit later when uart_set_options attemps to invoke set_termios on a
> port with an ops member equal to NULL.
>
> This patch just checks in sci_console_init that the port is properly
> initialized, and aborts the early console setup if it is not.
>
> Signed-off-by: Alexandre Courbot <gnurou@gmail.com>
Looks good. Applied, thanks.
prev parent reply other threads:[~2011-02-09 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 3:18 [PATCH] serial: sh-sci: prevent setup of uninitialized serial console Alexandre Courbot
2011-02-09 7:28 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209072822.GB16518@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).