From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Tue, 01 Mar 2011 08:06:24 +0000 Subject: Re: [PATCH] sh: Enable PMB support on SH4AL-DSP Message-Id: <20110301080623.GC5985@linux-sh.org> List-Id: References: <20110301064150.GB5985@linux-sh.org> In-Reply-To: <20110301064150.GB5985@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Tue, Mar 01, 2011 at 05:02:17PM +0900, Magnus Damm wrote: > On Tue, Mar 1, 2011 at 3:41 PM, Paul Mundt wrote: > > On Tue, Mar 01, 2011 at 03:45:14PM +0900, Magnus Damm wrote: > >> From: Magnus Damm > >> > >> The SH4AL-DSP core included in sh7372 requires use of the PMB, > >> update the CONFIG_PMB Kconfig entry to reflect this. > >> > >> Signed-off-by: Magnus Damm > > > > No. SH4AL-DSP does not in general have a PMB. If this CPU subtype is > > special, then it needs to be special cased. > > Well, SH4AL-DSP may not have a PMB in general, but it also may not > "not" have it either. > > This is what I can tell after going through data sheet for a bunch of > SH4AL-DSP SoCs: > > sh7722 SH4AL-DSP > sh7366 SH4AL-DSP > sh7343 SH4AL-DSP + EXT > sh7367 SH4AL-DSP + EXT + PMB + BOOT > sh7377 SH4AL-DSP + EXT + PMB + BOOT > sh7372 SH4AL-DSP + EXT + PMB + BOOT > > EXT = "SH4AL-DSP Extended Functions" > PMB = "32-bit Address Extended Mode" > BOOT = "32-bit Boot Function" > > From the table it looks like the SH4AL-DSP core can come with and without PMB. > That's a pretty special way of interpreting the results. > How would you like to special case it? > >From the above table we see that all SH4AL-DSPs that are standalone cores have no PMB functionality, and that the only ones that do are in ARM/SH multi-core configurations. This is what needs to be special cased. Implying that the potential existence of the PMB has anything at all to do with SH4AL-DSP outside of the SH/R-Mobile context is disingenous at best. If a standalone SH4AL-DSP pops up with PMB functionality in the future then of course that can be special cased too, but for now implying that SH4AL-DSP = PMB is absurd.