From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Wilson Date: Wed, 09 Mar 2011 14:14:41 +0000 Subject: Re: [PATCH 0/5] make *_gate_vma accept mm_struct instead of Message-Id: <20110309141441.GA8861@fibrous.localdomain> List-Id: References: <1299630721-4337-1-git-send-email-wilsons@start.ca> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Michel Lespinasse Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, Paul Mundt , Andi Kleen , Andrew Morton , Alexander Viro , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, Mar 09, 2011 at 05:09:09AM -0800, Michel Lespinasse wrote: > On Tue, Mar 8, 2011 at 4:31 PM, Stephen Wilson wrote: > > Morally, the question of whether an address lies in a gate vma should b= e asked > > with respect to an mm, not a particular task. > > > > Practically, dropping the dependency on task_struct will help make curr= ent and > > future operations on mm's more flexible and convenient. =A0In particula= r, it > > allows some code paths to avoid the need to hold task_lock. >=20 > Reviewed-by: Michel Lespinasse >=20 > May I suggest ia32_compat instead of just compat for the flag name ? Yes, sounds good to me. Will change in the next iteration. Thanks for the review! > --=20 > Michel "Walken" Lespinasse > A program is never fully debugged until the last user dies. --=20 steve