From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Date: Wed, 23 Mar 2011 20:39:39 +0000 Subject: Re: [PATCH 9/10] sh: Use struct syscore_ops instead of sysdev class and sysdev Message-Id: <201103232139.40115.rjw@sisk.pl> List-Id: References: <201103100131.58206.rjw@sisk.pl> <201103222119.28328.rjw@sisk.pl> <20110323095920.GA6008@linux-sh.org> In-Reply-To: <20110323095920.GA6008@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mundt Cc: LKML , Greg KH , Kay Sievers , Linux PM mailing list , Russell King , Magnus Damm , linux-sh@vger.kernel.org On Wednesday, March 23, 2011, Paul Mundt wrote: > On Tue, Mar 22, 2011 at 09:19:28PM +0100, Rafael J. Wysocki wrote: > > Convert the SuperH clocks framework and shared interrupt handling > > code to using struct syscore_ops instead of a sysdev classes and > > sysdevs for power managment. > > > > This reduces the code size significantly and simplifies it. The > > optimizations causing things not to be restored after creating a > > hibernation image are removed, but they might lead to undesirable > > effects during resume from hibernation (e.g. the clocks would be left > > as the boot kernel set them, which might be not the same way as the > > hibernated kernel had seen them before the hibernation). > > > > This also is necessary for removing sysdevs from the kernel entirely > > in the future. > > > > Signed-off-by: Rafael J. Wysocki > > --- > > drivers/sh/clk/core.c | 68 ++++++++----------------------- > > drivers/sh/intc/core.c | 95 +++++++++++++++++++++----------------------- > > drivers/sh/intc/internals.h | 1 > > 3 files changed, 65 insertions(+), 99 deletions(-) > > > This one looks good, and seems to work fine. Applied, thanks. Cool, thanks!