From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Mon, 18 Apr 2011 08:18:09 +0000 Subject: Re: [PATCH 8/9] OMAP1 / PM: Use generic clock manipulation routines for runtime PM Message-Id: <20110418081809.GA32457@linux-sh.org> List-Id: References: <201104130205.26988.rjw@sisk.pl> <201104170135.19388.rjw@sisk.pl> <201104170143.28980.rjw@sisk.pl> In-Reply-To: <201104170143.28980.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Rafael J. Wysocki" Cc: Linux PM mailing list , Kevin Hilman , LKML , Grant Likely , Len Brown , linux-sh@vger.kernel.org, Magnus Damm , Alan Stern , Greg KH On Sun, Apr 17, 2011 at 01:43:28AM +0200, Rafael J. Wysocki wrote: > @@ -75,24 +69,7 @@ static int __init omap1_pm_runtime_init( > if (!cpu_class_is_omap1()) > return -ENODEV; > > - pm = platform_bus_get_pm_ops(); > - if (!pm) { > - pr_err("%s: unable to get dev_pm_ops from platform_bus\n", > - __func__); > - return -ENODEV; > - } > - > - omap_pm = kmemdup(pm, sizeof(struct dev_pm_ops), GFP_KERNEL); > - if (!omap_pm) { > - pr_err("%s: unable to alloc memory for new dev_pm_ops\n", > - __func__); > - return -ENOMEM; > - } > - > - omap_pm->runtime_suspend = omap1_pm_runtime_suspend; > - omap_pm->runtime_resume = omap1_pm_runtime_resume; > - > - platform_bus_set_pm_ops(omap_pm); > + pm_runtim_clock_add_notifier(&platform_bus_type, &platform_bus_notifier); > Presumably you meant pm_runtime_clock_add_notifier() here. You seem to have the same typo in a few other places too.