From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: cosmetic improvement: use an existing pointer
Date: Mon, 18 Apr 2011 09:40:55 +0000 [thread overview]
Message-ID: <20110418094054.GH32457@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1104152004360.18593@axis700.grange>
On Sat, Apr 16, 2011 at 06:34:14PM +0800, Simon Horman wrote:
> On Fri, Apr 15, 2011 at 08:05:27PM +0200, Guennadi Liakhovetski wrote:
> > Use an existing local variable, instead of calculating the pointer
> > multiple times explicitly.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Cc: Simon Horman <horms@verge.net.au>
> > Cc: Magnus Damm <damm@opensource.se>
>
> This looks correct to me.
>
> Reviewed-by: Simon Horman <horms@verge.net.au>
I'll skip this for now given that there are quite a few people presently
hacking on this file and it's not worth generating conflicts over.
Feel free to resubmit on top of the unified framework once the dust
settles, though.
prev parent reply other threads:[~2011-04-18 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 18:05 [PATCH] sh: cosmetic improvement: use an existing pointer Guennadi Liakhovetski
2011-04-16 10:34 ` Simon Horman
2011-04-18 9:40 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418094054.GH32457@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).