[PATCH] sh: cosmetic improvement: use an existing pointer

[PATCH] sh: cosmetic improvement: use an existing pointer

[Guennadi Liakhovetski]

Use an existing local variable, instead of calculating the pointer
multiple times explicitly.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <damm@opensource.se>
---
 arch/sh/kernel/cpu/shmobile/pm_runtime.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/sh/kernel/cpu/shmobile/pm_runtime.c b/arch/sh/kernel/cpu/shmobile/pm_runtime.c
index 6dcb816..db56e3a 100644
--- a/arch/sh/kernel/cpu/shmobile/pm_runtime.c
+++ b/arch/sh/kernel/cpu/shmobile/pm_runtime.c
@@ -157,7 +157,7 @@ int platform_pm_runtime_suspend(struct device *dev)
 	might_sleep();
 
 	/* catch misconfigured drivers not starting with resume */
-	if (test_bit(PDEV_ARCHDATA_FLAG_INIT, &pdev->archdata.flags)) {
+	if (test_bit(PDEV_ARCHDATA_FLAG_INIT, &ad->flags)) {
 		ret = -EINVAL;
 		goto out;
 	}
@@ -170,8 +170,8 @@ int platform_pm_runtime_suspend(struct device *dev)
 
 	/* put device on idle list */
 	spin_lock_irqsave(&hwblk_lock, flags);
-	list_add_tail(&pdev->archdata.entry, &hwblk_idle_list);
-	__set_bit(PDEV_ARCHDATA_FLAG_IDLE, &pdev->archdata.flags);
+	list_add_tail(&ad->entry, &hwblk_idle_list);
+	__set_bit(PDEV_ARCHDATA_FLAG_IDLE, &ad->flags);
 	spin_unlock_irqrestore(&hwblk_lock, flags);
 
 	/* increase idle count */
-- 
1.7.2.5

Re: [PATCH] sh: cosmetic improvement: use an existing pointer

[Simon Horman]

On Fri, Apr 15, 2011 at 08:05:27PM +0200, Guennadi Liakhovetski wrote:
> Use an existing local variable, instead of calculating the pointer
> multiple times explicitly.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Magnus Damm <damm@opensource.se>

This looks correct to me.

Reviewed-by: Simon Horman <horms@verge.net.au>

Re: [PATCH] sh: cosmetic improvement: use an existing pointer

[Paul Mundt]

On Sat, Apr 16, 2011 at 06:34:14PM +0800, Simon Horman wrote:
> On Fri, Apr 15, 2011 at 08:05:27PM +0200, Guennadi Liakhovetski wrote:
> > Use an existing local variable, instead of calculating the pointer
> > multiple times explicitly.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Cc: Simon Horman <horms@verge.net.au>
> > Cc: Magnus Damm <damm@opensource.se>
> 
> This looks correct to me.
> 
> Reviewed-by: Simon Horman <horms@verge.net.au>

I'll skip this for now given that there are quite a few people presently
hacking on this file and it's not worth generating conflicts over.

Feel free to resubmit on top of the unified framework once the dust
settles, though.