From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Mon, 18 Apr 2011 09:40:55 +0000 Subject: Re: [PATCH] sh: cosmetic improvement: use an existing pointer Message-Id: <20110418094054.GH32457@linux-sh.org> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Sat, Apr 16, 2011 at 06:34:14PM +0800, Simon Horman wrote: > On Fri, Apr 15, 2011 at 08:05:27PM +0200, Guennadi Liakhovetski wrote: > > Use an existing local variable, instead of calculating the pointer > > multiple times explicitly. > > > > Signed-off-by: Guennadi Liakhovetski > > Cc: Simon Horman > > Cc: Magnus Damm > > This looks correct to me. > > Reviewed-by: Simon Horman I'll skip this for now given that there are quite a few people presently hacking on this file and it's not worth generating conflicts over. Feel free to resubmit on top of the unified framework once the dust settles, though.