* [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops
@ 2011-05-06 19:23 Richard Weinberger
2011-05-11 22:37 ` [PATCH] [RFC] remove warning and warning_symbol from struct Frederic Weisbecker
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2011-05-06 19:23 UTC (permalink / raw)
To: linux-kernel
Cc: linux-sh, oprofile-list, oleg, akpm, ying.huang, ssp, namhyung,
fweisbec, x86, hpa, tglx, robert.richter, Richard Weinberger
Both warning and warning_symbol are nowhere used.
Let's get rid of them.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
arch/sh/include/asm/stacktrace.h | 3 ---
arch/sh/kernel/dumpstack.c | 15 ---------------
arch/sh/kernel/perf_callchain.c | 12 ------------
arch/sh/kernel/stacktrace.c | 13 -------------
arch/sh/oprofile/backtrace.c | 13 -------------
arch/x86/include/asm/stacktrace.h | 3 ---
arch/x86/kernel/cpu/perf_event.c | 13 -------------
arch/x86/kernel/dumpstack.c | 16 ----------------
arch/x86/kernel/stacktrace.c | 13 -------------
arch/x86/oprofile/backtrace.c | 13 -------------
10 files changed, 0 insertions(+), 114 deletions(-)
diff --git a/arch/sh/include/asm/stacktrace.h b/arch/sh/include/asm/stacktrace.h
index 7970182..a7e2d4d 100644
--- a/arch/sh/include/asm/stacktrace.h
+++ b/arch/sh/include/asm/stacktrace.h
@@ -10,9 +10,6 @@
/* Generic stack tracer with callbacks */
struct stacktrace_ops {
- void (*warning)(void *data, char *msg);
- /* msg must contain %s for the symbol */
- void (*warning_symbol)(void *data, char *msg, unsigned long symbol);
void (*address)(void *data, unsigned long address, int reliable);
/* On negative return stop dumping */
int (*stack)(void *data, char *name);
diff --git a/arch/sh/kernel/dumpstack.c b/arch/sh/kernel/dumpstack.c
index 6f5ad15..694158b 100644
--- a/arch/sh/kernel/dumpstack.c
+++ b/arch/sh/kernel/dumpstack.c
@@ -69,19 +69,6 @@ stack_reader_dump(struct task_struct *task, struct pt_regs *regs,
}
}
-static void
-print_trace_warning_symbol(void *data, char *msg, unsigned long symbol)
-{
- printk(data);
- print_symbol(msg, symbol);
- printk("\n");
-}
-
-static void print_trace_warning(void *data, char *msg)
-{
- printk("%s%s\n", (char *)data, msg);
-}
-
static int print_trace_stack(void *data, char *name)
{
printk("%s <%s> ", (char *)data, name);
@@ -98,8 +85,6 @@ static void print_trace_address(void *data, unsigned long addr, int reliable)
}
static const struct stacktrace_ops print_trace_ops = {
- .warning = print_trace_warning,
- .warning_symbol = print_trace_warning_symbol,
.stack = print_trace_stack,
.address = print_trace_address,
};
diff --git a/arch/sh/kernel/perf_callchain.c b/arch/sh/kernel/perf_callchain.c
index d5ca1ef..cc80b61 100644
--- a/arch/sh/kernel/perf_callchain.c
+++ b/arch/sh/kernel/perf_callchain.c
@@ -14,16 +14,6 @@
#include <asm/unwinder.h>
#include <asm/ptrace.h>
-
-static void callchain_warning(void *data, char *msg)
-{
-}
-
-static void
-callchain_warning_symbol(void *data, char *msg, unsigned long symbol)
-{
-}
-
static int callchain_stack(void *data, char *name)
{
return 0;
@@ -38,8 +28,6 @@ static void callchain_address(void *data, unsigned long addr, int reliable)
}
static const struct stacktrace_ops callchain_ops = {
- .warning = callchain_warning,
- .warning_symbol = callchain_warning_symbol,
.stack = callchain_stack,
.address = callchain_address,
};
diff --git a/arch/sh/kernel/stacktrace.c b/arch/sh/kernel/stacktrace.c
index c2e45c4..bf989e0 100644
--- a/arch/sh/kernel/stacktrace.c
+++ b/arch/sh/kernel/stacktrace.c
@@ -17,15 +17,6 @@
#include <asm/ptrace.h>
#include <asm/stacktrace.h>
-static void save_stack_warning(void *data, char *msg)
-{
-}
-
-static void
-save_stack_warning_symbol(void *data, char *msg, unsigned long symbol)
-{
-}
-
static int save_stack_stack(void *data, char *name)
{
return 0;
@@ -51,8 +42,6 @@ static void save_stack_address(void *data, unsigned long addr, int reliable)
}
static const struct stacktrace_ops save_stack_ops = {
- .warning = save_stack_warning,
- .warning_symbol = save_stack_warning_symbol,
.stack = save_stack_stack,
.address = save_stack_address,
};
@@ -88,8 +77,6 @@ save_stack_address_nosched(void *data, unsigned long addr, int reliable)
}
static const struct stacktrace_ops save_stack_ops_nosched = {
- .warning = save_stack_warning,
- .warning_symbol = save_stack_warning_symbol,
.stack = save_stack_stack,
.address = save_stack_address_nosched,
};
diff --git a/arch/sh/oprofile/backtrace.c b/arch/sh/oprofile/backtrace.c
index 37f3a75..9c88dcd 100644
--- a/arch/sh/oprofile/backtrace.c
+++ b/arch/sh/oprofile/backtrace.c
@@ -23,17 +23,6 @@
#include <asm/sections.h>
#include <asm/stacktrace.h>
-static void backtrace_warning_symbol(void *data, char *msg,
- unsigned long symbol)
-{
- /* Ignore warnings */
-}
-
-static void backtrace_warning(void *data, char *msg)
-{
- /* Ignore warnings */
-}
-
static int backtrace_stack(void *data, char *name)
{
/* Yes, we want all stacks */
@@ -49,8 +38,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable)
}
static struct stacktrace_ops backtrace_ops = {
- .warning = backtrace_warning,
- .warning_symbol = backtrace_warning_symbol,
.stack = backtrace_stack,
.address = backtrace_address,
};
diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h
index d7e89c8..70bbe39 100644
--- a/arch/x86/include/asm/stacktrace.h
+++ b/arch/x86/include/asm/stacktrace.h
@@ -37,9 +37,6 @@ print_context_stack_bp(struct thread_info *tinfo,
/* Generic stack tracer with callbacks */
struct stacktrace_ops {
- void (*warning)(void *data, char *msg);
- /* msg must contain %s for the symbol */
- void (*warning_symbol)(void *data, char *msg, unsigned long symbol);
void (*address)(void *data, unsigned long address, int reliable);
/* On negative return stop dumping */
int (*stack)(void *data, char *name);
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
index e638689..2828bca 100644
--- a/arch/x86/kernel/cpu/perf_event.c
+++ b/arch/x86/kernel/cpu/perf_event.c
@@ -1766,17 +1766,6 @@ static struct pmu pmu = {
* callchain support
*/
-static void
-backtrace_warning_symbol(void *data, char *msg, unsigned long symbol)
-{
- /* Ignore warnings */
-}
-
-static void backtrace_warning(void *data, char *msg)
-{
- /* Ignore warnings */
-}
-
static int backtrace_stack(void *data, char *name)
{
return 0;
@@ -1790,8 +1779,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable)
}
static const struct stacktrace_ops backtrace_ops = {
- .warning = backtrace_warning,
- .warning_symbol = backtrace_warning_symbol,
.stack = backtrace_stack,
.address = backtrace_address,
.walk_stack = print_context_stack_bp,
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index e2a3f06..f478ff6 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -135,20 +135,6 @@ print_context_stack_bp(struct thread_info *tinfo,
}
EXPORT_SYMBOL_GPL(print_context_stack_bp);
-
-static void
-print_trace_warning_symbol(void *data, char *msg, unsigned long symbol)
-{
- printk(data);
- print_symbol(msg, symbol);
- printk("\n");
-}
-
-static void print_trace_warning(void *data, char *msg)
-{
- printk("%s%s\n", (char *)data, msg);
-}
-
static int print_trace_stack(void *data, char *name)
{
printk("%s <%s> ", (char *)data, name);
@@ -166,8 +152,6 @@ static void print_trace_address(void *data, unsigned long addr, int reliable)
}
static const struct stacktrace_ops print_trace_ops = {
- .warning = print_trace_warning,
- .warning_symbol = print_trace_warning_symbol,
.stack = print_trace_stack,
.address = print_trace_address,
.walk_stack = print_context_stack,
diff --git a/arch/x86/kernel/stacktrace.c b/arch/x86/kernel/stacktrace.c
index 6515733..55d9bc0 100644
--- a/arch/x86/kernel/stacktrace.c
+++ b/arch/x86/kernel/stacktrace.c
@@ -9,15 +9,6 @@
#include <linux/uaccess.h>
#include <asm/stacktrace.h>
-static void save_stack_warning(void *data, char *msg)
-{
-}
-
-static void
-save_stack_warning_symbol(void *data, char *msg, unsigned long symbol)
-{
-}
-
static int save_stack_stack(void *data, char *name)
{
return 0;
@@ -53,16 +44,12 @@ save_stack_address_nosched(void *data, unsigned long addr, int reliable)
}
static const struct stacktrace_ops save_stack_ops = {
- .warning = save_stack_warning,
- .warning_symbol = save_stack_warning_symbol,
.stack = save_stack_stack,
.address = save_stack_address,
.walk_stack = print_context_stack,
};
static const struct stacktrace_ops save_stack_ops_nosched = {
- .warning = save_stack_warning,
- .warning_symbol = save_stack_warning_symbol,
.stack = save_stack_stack,
.address = save_stack_address_nosched,
.walk_stack = print_context_stack,
diff --git a/arch/x86/oprofile/backtrace.c b/arch/x86/oprofile/backtrace.c
index 2d49d4e..a5b64ab 100644
--- a/arch/x86/oprofile/backtrace.c
+++ b/arch/x86/oprofile/backtrace.c
@@ -16,17 +16,6 @@
#include <asm/stacktrace.h>
#include <linux/compat.h>
-static void backtrace_warning_symbol(void *data, char *msg,
- unsigned long symbol)
-{
- /* Ignore warnings */
-}
-
-static void backtrace_warning(void *data, char *msg)
-{
- /* Ignore warnings */
-}
-
static int backtrace_stack(void *data, char *name)
{
/* Yes, we want all stacks */
@@ -42,8 +31,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable)
}
static struct stacktrace_ops backtrace_ops = {
- .warning = backtrace_warning,
- .warning_symbol = backtrace_warning_symbol,
.stack = backtrace_stack,
.address = backtrace_address,
.walk_stack = print_context_stack,
--
1.7.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [RFC] remove warning and warning_symbol from struct
2011-05-06 19:23 [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops Richard Weinberger
@ 2011-05-11 22:37 ` Frederic Weisbecker
2011-05-12 12:48 ` [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Frederic Weisbecker @ 2011-05-11 22:37 UTC (permalink / raw)
To: Richard Weinberger
Cc: linux-kernel, linux-sh, oprofile-list, oleg, akpm, ying.huang,
ssp, namhyung, x86, hpa, tglx, robert.richter, Ingo Molnar
On Fri, May 06, 2011 at 09:23:11PM +0200, Richard Weinberger wrote:
> Both warning and warning_symbol are nowhere used.
> Let's get rid of them.
I have no clue what it was used for. But fine let's assume
it's a leftover of some previous removal.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/sh/include/asm/stacktrace.h | 3 ---
> arch/sh/kernel/dumpstack.c | 15 ---------------
> arch/sh/kernel/perf_callchain.c | 12 ------------
> arch/sh/kernel/stacktrace.c | 13 -------------
> arch/sh/oprofile/backtrace.c | 13 -------------
Can you please split your patch in two parts: one for sh and
another for x86?
Thanks.
> arch/x86/include/asm/stacktrace.h | 3 ---
> arch/x86/kernel/cpu/perf_event.c | 13 -------------
> arch/x86/kernel/dumpstack.c | 16 ----------------
> arch/x86/kernel/stacktrace.c | 13 -------------
> arch/x86/oprofile/backtrace.c | 13 -------------
> 10 files changed, 0 insertions(+), 114 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops
2011-05-11 22:37 ` [PATCH] [RFC] remove warning and warning_symbol from struct Frederic Weisbecker
@ 2011-05-12 12:48 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2011-05-12 12:48 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: linux-kernel, linux-sh, oprofile-list, oleg, akpm, ying.huang,
ssp, namhyung, x86, hpa, tglx, robert.richter, Ingo Molnar
Am Donnerstag 12 Mai 2011, 00:37:23 schrieb Frederic Weisbecker:
> On Fri, May 06, 2011 at 09:23:11PM +0200, Richard Weinberger wrote:
> > Both warning and warning_symbol are nowhere used.
> > Let's get rid of them.
>
> I have no clue what it was used for. But fine let's assume
> it's a leftover of some previous removal.
>
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> > ---
> >
> > arch/sh/include/asm/stacktrace.h | 3 ---
> > arch/sh/kernel/dumpstack.c | 15 ---------------
> > arch/sh/kernel/perf_callchain.c | 12 ------------
> > arch/sh/kernel/stacktrace.c | 13 -------------
> > arch/sh/oprofile/backtrace.c | 13 -------------
>
> Can you please split your patch in two parts: one for sh and
> another for x86?
Sure. Will resend!
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-12 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-06 19:23 [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops Richard Weinberger
2011-05-11 22:37 ` [PATCH] [RFC] remove warning and warning_symbol from struct Frederic Weisbecker
2011-05-12 12:48 ` [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).