* [PATCH] usb: renesas_usbhs: use dma handler
@ 2011-06-21 6:09 Kuninori Morimoto
2011-06-21 8:37 ` Paul Mundt
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2011-06-21 6:09 UTC (permalink / raw)
To: linux-sh
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c
index ce35319..da76634 100644
--- a/drivers/usb/renesas_usbhs/mod_gadget.c
+++ b/drivers/usb/renesas_usbhs/mod_gadget.c
@@ -485,9 +485,9 @@ static int usbhsg_ep_enable(struct usb_ep *ep,
pipe->mod_private = uep;
if (usb_endpoint_dir_in(desc))
- uep->handler = &usbhs_fifo_pio_push_handler;
+ uep->handler = &usbhs_fifo_dma_push_handler;
else
- uep->handler = &usbhs_fifo_pio_pop_handler;
+ uep->handler = &usbhs_fifo_dma_pop_handler;
ret = 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] usb: renesas_usbhs: use dma handler
2011-06-21 6:09 [PATCH] usb: renesas_usbhs: use dma handler Kuninori Morimoto
@ 2011-06-21 8:37 ` Paul Mundt
2011-06-21 10:34 ` Kuninori Morimoto
2011-06-24 7:11 ` Paul Mundt
2 siblings, 0 replies; 4+ messages in thread
From: Paul Mundt @ 2011-06-21 8:37 UTC (permalink / raw)
To: linux-sh
On Tue, Jun 21, 2011 at 03:09:19PM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Does this have any dependencies? What about platforms that don't support
dmaengine?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: renesas_usbhs: use dma handler
2011-06-21 6:09 [PATCH] usb: renesas_usbhs: use dma handler Kuninori Morimoto
2011-06-21 8:37 ` Paul Mundt
@ 2011-06-21 10:34 ` Kuninori Morimoto
2011-06-24 7:11 ` Paul Mundt
2 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2011-06-21 10:34 UTC (permalink / raw)
To: linux-sh
Dear Paul
Thank you for your check
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> Does this have any dependencies? What about platforms that don't support
> dmaengine?
renesas_usbhs driver will use PIO mode if platforms doesn't have/support
dmaengine
more explain or rename needed ?
Best regards
--
Kuninori Morimoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: renesas_usbhs: use dma handler
2011-06-21 6:09 [PATCH] usb: renesas_usbhs: use dma handler Kuninori Morimoto
2011-06-21 8:37 ` Paul Mundt
2011-06-21 10:34 ` Kuninori Morimoto
@ 2011-06-24 7:11 ` Paul Mundt
2 siblings, 0 replies; 4+ messages in thread
From: Paul Mundt @ 2011-06-24 7:11 UTC (permalink / raw)
To: linux-sh
On Tue, Jun 21, 2011 at 07:34:17PM +0900, Kuninori Morimoto wrote:
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > Does this have any dependencies? What about platforms that don't support
> > dmaengine?
>
> renesas_usbhs driver will use PIO mode if platforms doesn't have/support
> dmaengine
>
> more explain or rename needed ?
>
No, that's fine. It wasn't immediately obvious that the PIO fallback and
overriding of the handler was being done in the DMA routines. Looks good
to me, I'll let Greg pick it up for usb-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-24 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-21 6:09 [PATCH] usb: renesas_usbhs: use dma handler Kuninori Morimoto
2011-06-21 8:37 ` Paul Mundt
2011-06-21 10:34 ` Kuninori Morimoto
2011-06-24 7:11 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox