From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] drivers: sh: late disabling of clocks V2
Date: Fri, 24 Jun 2011 08:43:26 +0000 [thread overview]
Message-ID: <20110624084322.GA20385@verge.net.au> (raw)
In-Reply-To: <20110621075512.24672.78879.sendpatchset@t400s>
On Fri, Jun 24, 2011 at 04:33:05PM +0900, Paul Mundt wrote:
> On Tue, Jun 21, 2011 at 07:32:36PM +0900, Simon Horman wrote:
> > On Tue, Jun 21, 2011 at 04:55:12PM +0900, Magnus Damm wrote:
> > > From: Magnus Damm <damm@opensource.se>
> > >
> > > This V2 patch changes the clock disabling behavior during boot.
> > > Two different changes are made:
> > >
> > > 1) Delay disabling of clocks until late in the boot process.
> > > This fixes an existing issue where in-use clocks without
> > > software reference are disabled by mistake during boot.
> > > One example of this is the handling of the Mackerel serial
> > > console output that shares clock with the I2C controller.
> > >
> > > 2) Write out the "disabled" state to the hardware for clocks
> > > that not have been used by the kernel. In other words,
> > > make sure so far unused clocks actually get turned off.
> > >
> > > Signed-off-by: Magnus Damm <damm@opensource.se>
> > > ---
> > >
> > > Changes since V1:
> > > - move out the spinlock and let it protect allow_disable
> > >
> > > Thanks to Simon Horman for code improvements.
> > >
> > > This would be useful to have in a topic branch so we can
> > > go through each platform and extend the clock framework
> > > to a more complete coverage.
> >
> > Code improvement aspect
> > Acked-by: Simon Horman <horms@verge.net.au>
> >
> Applied to sh/clkfwk and subsequently rolled in to sh-latest. Lets see
> what breaks..
Friday Fun!
prev parent reply other threads:[~2011-06-24 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 7:55 [PATCH] drivers: sh: late disabling of clocks V2 Magnus Damm
2011-06-21 10:32 ` Simon Horman
2011-06-24 7:33 ` Paul Mundt
2011-06-24 8:43 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624084322.GA20385@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox