From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM mailing list <linux-pm@lists.linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Magnus Damm <magnus.damm@gmail.com>,
Paul Walmsley <paul@pwsan.com>, Kevin Hilman <khilman@ti.com>,
Alan Stern <stern@rowland.harvard.edu>,
LKML <linux-kernel@vger.kernel.org>,
linux-sh@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>
Subject: [PATCH 8/10 v6] PM: Allow the clocks management code to be used during system suspend
Date: Sat, 25 Jun 2011 21:30:05 +0000 [thread overview]
Message-ID: <201106252330.05596.rjw@sisk.pl> (raw)
In-Reply-To: <201106252324.13454.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
The common clocks management code in drivers/base/power/clock_ops.c
is going to be used during system-wide power transitions as well as
for runtime PM, so it shouldn't depend on CONFIG_PM_RUNTIME.
However, the suspend/resume functions provided by it for
CONFIG_PM_RUNTIME unset, to be used during system-wide power
transitions, should not behave in the same way as their counterparts
defined for CONFIG_PM_RUNTIME set, because in that case the clocks
are managed differently at run time.
The names of the functions still contain the word "runtime" after
this change, but that is going to be modified by a separate patch
later.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/base/power/clock_ops.c | 60 ++++++++++++++++++++++++++++++++++++++++-
include/linux/pm_runtime.h | 2 -
kernel/power/Kconfig | 4 +-
3 files changed, 62 insertions(+), 4 deletions(-)
Index: linux-2.6/include/linux/pm_runtime.h
=================================--- linux-2.6.orig/include/linux/pm_runtime.h
+++ linux-2.6/include/linux/pm_runtime.h
@@ -251,7 +251,7 @@ struct pm_clk_notifier_block {
char *con_ids[];
};
-#ifdef CONFIG_PM_RUNTIME_CLK
+#ifdef CONFIG_PM_CLK
extern int pm_runtime_clk_init(struct device *dev);
extern void pm_runtime_clk_destroy(struct device *dev);
extern int pm_runtime_clk_add(struct device *dev, const char *con_id);
Index: linux-2.6/kernel/power/Kconfig
=================================--- linux-2.6.orig/kernel/power/Kconfig
+++ linux-2.6/kernel/power/Kconfig
@@ -224,9 +224,9 @@ config PM_OPP
implementations a ready to use framework to manage OPPs.
For more information, read <file:Documentation/power/opp.txt>
-config PM_RUNTIME_CLK
+config PM_CLK
def_bool y
- depends on PM_RUNTIME && HAVE_CLK
+ depends on PM && HAVE_CLK
config PM_GENERIC_DOMAINS
bool
Index: linux-2.6/drivers/base/power/clock_ops.c
=================================--- linux-2.6.orig/drivers/base/power/clock_ops.c
+++ linux-2.6/drivers/base/power/clock_ops.c
@@ -15,7 +15,7 @@
#include <linux/slab.h>
#include <linux/err.h>
-#ifdef CONFIG_PM_RUNTIME
+#ifdef CONFIG_PM
struct pm_runtime_clk_data {
struct list_head clock_list;
@@ -191,6 +191,10 @@ void pm_runtime_clk_destroy(struct devic
kfree(prd);
}
+#endif /* CONFIG_PM */
+
+#ifdef CONFIG_PM_RUNTIME
+
/**
* pm_runtime_clk_acquire - Acquire a device clock.
* @dev: Device whose clock is to be acquired.
@@ -330,6 +334,60 @@ static int pm_runtime_clk_notify(struct
#else /* !CONFIG_PM_RUNTIME */
+#ifdef CONFIG_PM
+
+/**
+ * pm_runtime_clk_suspend - Disable clocks in a device's PM clock list.
+ * @dev: Device to disable the clocks for.
+ */
+int pm_runtime_clk_suspend(struct device *dev)
+{
+ struct pm_runtime_clk_data *prd = __to_prd(dev);
+ struct pm_clock_entry *ce;
+
+ dev_dbg(dev, "%s()\n", __func__);
+
+ /* If there is no driver, the clocks are already disabled. */
+ if (!prd || !dev->driver)
+ return 0;
+
+ mutex_lock(&prd->lock);
+
+ list_for_each_entry_reverse(ce, &prd->clock_list, node)
+ clk_disable(ce->clk);
+
+ mutex_unlock(&prd->lock);
+
+ return 0;
+}
+
+/**
+ * pm_runtime_clk_resume - Enable clocks in a device's PM clock list.
+ * @dev: Device to enable the clocks for.
+ */
+int pm_runtime_clk_resume(struct device *dev)
+{
+ struct pm_runtime_clk_data *prd = __to_prd(dev);
+ struct pm_clock_entry *ce;
+
+ dev_dbg(dev, "%s()\n", __func__);
+
+ /* If there is no driver, the clocks should remain disabled. */
+ if (!prd || !dev->driver)
+ return 0;
+
+ mutex_lock(&prd->lock);
+
+ list_for_each_entry(ce, &prd->clock_list, node)
+ clk_enable(ce->clk);
+
+ mutex_unlock(&prd->lock);
+
+ return 0;
+}
+
+#endif /* CONFIG_PM */
+
/**
* enable_clock - Enable a device clock.
* @dev: Device whose clock is to be enabled.
next prev parent reply other threads:[~2011-06-25 21:30 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 20:23 [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Rafael J. Wysocki
2011-06-11 20:25 ` [PATCH 1/8] PM / Domains: Update documentation Rafael J. Wysocki
2011-06-11 20:26 ` [PATCH 2/8] PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain Rafael J. Wysocki
2011-06-20 23:37 ` Kevin Hilman
2011-06-11 20:27 ` [PATCH 3/8] PM: subsys_data in struct dev_pm_info need not depend on RM_RUNTIME Rafael J. Wysocki
2011-06-11 20:31 ` [PATCH 4/8] PM / Domains: Support for generic I/O PM domains (v5) Rafael J. Wysocki
2011-06-19 22:02 ` [Update][PATCH 4/8] PM / Domains: Support for generic I/O PM domains (v6) Rafael J. Wysocki
2011-06-21 17:42 ` Kevin Hilman
2011-06-22 0:07 ` Rafael J. Wysocki
2011-06-22 19:51 ` Kevin Hilman
2011-06-22 21:30 ` Rafael J. Wysocki
2011-06-11 20:36 ` [PATCH 5/8] PM: Introduce generic "noirq" callback routines for subsystems Rafael J. Wysocki
2011-06-11 20:37 ` [PATCH 6/8] PM / Domains: Move code from under #ifdef CONFIG_PM_RUNTIME Rafael J. Wysocki
2011-06-11 20:39 ` [PATCH 7/8] PM / Domains: System-wide transitions support for generic PM domains Rafael J. Wysocki
2011-06-11 23:28 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v2) Rafael J. Wysocki
2011-06-23 14:19 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support Alan Stern
2011-06-23 14:44 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Rafael J. Wysocki
2011-06-23 15:11 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support Alan Stern
2011-06-23 17:41 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Rafael J. Wysocki
2011-06-23 18:22 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support Alan Stern
2011-06-23 21:03 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Rafael J. Wysocki
2011-06-19 22:06 ` Rafael J. Wysocki
2011-06-20 23:05 ` Rafael J. Wysocki
2011-06-22 21:50 ` Kevin Hilman
2011-06-22 22:16 ` Rafael J. Wysocki
2011-06-22 22:18 ` Kevin Hilman
2011-06-22 22:22 ` Rafael J. Wysocki
2011-06-23 13:57 ` [PATCH] PM / Runtime: Update documentation of interactions with system sleep Rafael J. Wysocki
2011-06-24 18:25 ` Kevin Hilman
2011-06-11 20:40 ` [PATCH 8/8] ARM / shmobile: Support for I/O PM domains for SH7372 (v5) Rafael J. Wysocki
2011-06-14 13:12 ` Magnus Damm
2011-06-14 21:16 ` Rafael J. Wysocki
2011-06-15 14:17 ` Magnus Damm
2011-06-15 23:06 ` Rafael J. Wysocki
2011-06-19 22:07 ` [Update][PATCH 8/8] ARM / shmobile: Support for I/O power domains for SH7372 (v6) Rafael J. Wysocki
2011-06-20 2:01 ` Paul Mundt
2011-06-20 22:30 ` Rafael J. Wysocki
2011-06-21 11:57 ` Rafael J. Wysocki
2011-06-21 12:47 ` Paul Mundt
2011-07-10 11:45 ` [PATCH 8/8] ARM / shmobile: Support for I/O PM domains for SH7372 (v5) Laurent Pinchart
2011-06-11 20:57 ` [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Greg KH
2011-06-21 0:02 ` Kevin Hilman
2011-06-21 11:06 ` Rafael J. Wysocki
2011-06-21 14:47 ` [PATCH 0/8] PM / Domains: Support for generic I/O PM domains Kevin Hilman
2011-06-25 21:24 ` [PATCH 0/10 v6] " Rafael J. Wysocki
2011-06-25 21:24 ` [PATCH 1/10 v6] PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain Rafael J. Wysocki
2011-06-25 21:25 ` [PATCH 2/10 v6] PM: subsys_data in struct dev_pm_info need not depend on RM_RUNTIME Rafael J. Wysocki
2011-06-25 21:26 ` [PATCH 3/10 v6] PM / Domains: Support for generic I/O PM domains (v7) Rafael J. Wysocki
2011-06-30 6:14 ` Ming Lei
2011-06-30 18:58 ` Rafael J. Wysocki
2011-07-01 18:11 ` Kevin Hilman
2011-07-01 20:03 ` Rafael J. Wysocki
2011-06-25 21:27 ` [PATCH 4/10 v6] PM: Introduce generic "noirq" callback routines for subsystems (v2) Rafael J. Wysocki
2011-06-25 21:27 ` [PATCH 5/10 v6] PM / Domains: Move code from under #ifdef CONFIG_PM_RUNTIME (v2) Rafael J. Wysocki
2011-06-25 21:28 ` [PATCH 6/10 v6] PM / Domains: System-wide transitions support for generic domains (v4) Rafael J. Wysocki
2011-06-28 23:44 ` [Update][PATCH 6/10] PM / Domains: System-wide transitions support for generic domains (v5) Rafael J. Wysocki
2011-07-08 0:29 ` Kevin Hilman
2011-07-08 9:24 ` Rafael J. Wysocki
2011-07-08 14:37 ` [Update][PATCH 6/10] PM / Domains: System-wide transitions Alan Stern
2011-07-08 17:20 ` [Update][PATCH 6/10] PM / Domains: System-wide transitions support for generic domains (v5) Kevin Hilman
2011-07-08 18:06 ` Rafael J. Wysocki
2011-07-08 19:24 ` Rafael J. Wysocki
2011-07-09 14:15 ` Rafael J. Wysocki
2011-07-11 15:37 ` Kevin Hilman
2011-07-11 19:39 ` Rafael J. Wysocki
2011-07-08 17:56 ` Rafael J. Wysocki
2011-06-25 21:29 ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Rafael J. Wysocki
2011-06-29 23:50 ` Kevin Hilman
2011-06-30 19:37 ` Rafael J. Wysocki
2011-06-30 22:42 ` Kevin Hilman
2011-06-30 22:55 ` Rafael J. Wysocki
2011-06-30 23:14 ` Kevin Hilman
2011-06-30 23:28 ` Rafael J. Wysocki
2011-07-01 0:01 ` Kevin Hilman
2011-07-01 0:24 ` Rafael J. Wysocki
2011-07-01 14:34 ` Kevin Hilman
2011-06-30 23:25 ` Rafael J. Wysocki
2011-07-01 14:45 ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during Alan Stern
2011-07-01 20:06 ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Rafael J. Wysocki
2011-06-25 21:30 ` Rafael J. Wysocki [this message]
2011-06-25 21:30 ` [PATCH 9/10 v6] PM: Rename clock management functions Rafael J. Wysocki
2011-06-25 21:31 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains for SH7372 (v8) Rafael J. Wysocki
2011-06-27 4:07 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains Magnus Damm
2011-06-27 19:25 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains for SH7372 (v8) Rafael J. Wysocki
2011-06-27 23:21 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains Magnus Damm
2011-06-28 10:08 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains for SH7372 (v8) Rafael J. Wysocki
2011-07-01 18:27 ` [PATCH 0/10 v6] PM / Domains: Support for generic I/O PM domains Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106252330.05596.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=gregkh@suse.de \
--cc=khilman@ti.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=paul@pwsan.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox