From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-shmobile: sh7372 generic suspend/resume
Date: Thu, 07 Jul 2011 13:50:43 +0000 [thread overview]
Message-ID: <20110707135043.GQ8286@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110707134813.22370.25948.sendpatchset@t400s>
On Thu, Jul 07, 2011 at 10:48:13PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Convert the sh7372 Core Standby code to make use
> of the new generic ARM cpu suspend/resume code.
Thanks. Only thing which stands out is:
> + .global sh7372_resume_core_standby
> +sh7372_resume_core_standby:
> + ldr pc, 1f
> +1: .long cpu_resume - PAGE_OFFSET + PLAT_PHYS_OFFSET
Is this because sh7372_resume_core_standby must be ARM stuff, but
cpu_resume may be Thumb?
I suspect we should make cpu_resume always be ARM instructions because I'd
imagine a lot of firmware won't cope with Thumb entry.
next prev parent reply other threads:[~2011-07-07 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 13:48 [PATCH] ARM: mach-shmobile: sh7372 generic suspend/resume support Magnus Damm
2011-07-07 13:50 ` Russell King - ARM Linux [this message]
2011-07-13 11:05 ` Magnus Damm
2011-07-13 12:34 ` [PATCH] ARM: mach-shmobile: sh7372 generic suspend/resume Russell King - ARM Linux
2011-08-03 4:45 ` [PATCH] ARM: mach-shmobile: sh7372 generic suspend/resume support Magnus Damm
2012-03-28 6:53 ` [PATCH] ARM: mach-shmobile: sh7372 generic board support via DT V2 Magnus Damm
2012-03-28 22:32 ` Rafael J. Wysocki
2012-03-29 4:48 ` Magnus Damm
2012-03-29 20:40 ` Rafael J. Wysocki
2012-03-30 6:22 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707135043.GQ8286@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox