From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/07] ARM: mach-shmobile: Kota2 SCIFA2 and SMSC911X support
Date: Mon, 22 Aug 2011 03:43:29 +0000 [thread overview]
Message-ID: <20110822034328.GK32513@linux-sh.org> (raw)
In-Reply-To: <20110818054407.23410.98641.sendpatchset@rxone.opensource.se>
On Thu, Aug 18, 2011 at 02:44:07PM +0900, Magnus Damm wrote:
> +static void __init kota2_timer_init(void)
> +{
> + sh73a0_clock_init();
> + shmobile_timer.init();
> + return;
> +}
> +
Pointless return.
> --- 0001/arch/arm/mach-shmobile/platsmp.c
> +++ work/arch/arm/mach-shmobile/platsmp.c 2011-08-18 13:38:02.000000000 +0900
> @@ -21,9 +21,11 @@
> #include <asm/mach-types.h>
> #include <mach/common.h>
>
> +#define is_sh73a0() (machine_is_ag5evm() || machine_is_kota2())
> +
> static unsigned int __init shmobile_smp_get_core_count(void)
> {
> - if (machine_is_ag5evm())
> + if (is_sh73a0())
> return sh73a0_get_core_count();
>
> return 1;
No. If you want to do this then simply do what the other platforms are
doing and construct a cpu.h, then you can centrally define things and use
cpu_is_xxx() outright. Making CPU inferences from mach type is just
asking for trouble.
next prev parent reply other threads:[~2011-08-22 3:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 5:44 [PATCH 01/07] ARM: mach-shmobile: Kota2 SCIFA2 and SMSC911X support Magnus Damm
2011-08-22 3:43 ` Paul Mundt [this message]
2011-11-04 14:14 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822034328.GK32513@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox