From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Date: Mon, 26 Sep 2011 08:39:24 +0000 Subject: Re: [BUG] on sh7372 (mackerel) with today's Linus' (github) master Message-Id: <20110926083924.GD22455@n2100.arm.linux.org.uk> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Sat, Sep 24, 2011 at 03:07:07PM +0200, Rafael J. Wysocki wrote: > On Saturday, September 24, 2011, Russell King - ARM Linux wrote: > > On Sat, Sep 24, 2011 at 12:58:37AM +0200, Rafael J. Wysocki wrote: > > > Well, since nobody seems to execute anything that may sleep under > > > clocks_mutex, perhaps we can do something like this: > > > > No - a spinlock prevents preemption, a mutex does not. > > > > It's runtime PM which is doing stuff wrong here. You're not supposed to > > give up the clk struct with it enabled. > > OK, so below is a fix confined to clock_ops.c. Looks fine from a read-through the patch, thanks. Acked-by: Russell King