From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] sh: Take into account the base of System RAM in
Date: Wed, 12 Oct 2011 22:42:46 +0000 [thread overview]
Message-ID: <20111012224238.GE16825@verge.net.au> (raw)
In-Reply-To: <1317603918-30762-1-git-send-email-horms@verge.net.au>
On Wed, Oct 12, 2011 at 05:24:23PM +0900, Magnus Damm wrote:
> On Mon, Oct 3, 2011 at 10:05 AM, Simon Horman <horms@verge.net.au> wrote:
> > Previously virt_to_phys() assumed that physical memory always started
> > at address 0. This is not always the case.
> >
> > Tested on an sh7757lcr (32bit system) whose only System RAM region is
> > 40000000-4effffff and an ecovec24 (29bit system).
> >
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > ---
> > kexec/arch/sh/kexec-sh.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
> > 1 files changed, 44 insertions(+), 1 deletions(-)
> >
> > v2
> > * Only use the base of System RAM as an offset into physical memory
> > if 32bit addressing is in use.
>
> This version looks much better, thanks!
I thought so too. But after pushing it I realised the parsing logic in
is_32bit() is flawed. I will send an update.
next prev parent reply other threads:[~2011-10-12 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 1:05 [PATCH v2] sh: Take into account the base of System RAM in virt_to_phys() Simon Horman
2011-10-12 8:24 ` Magnus Damm
2011-10-12 22:42 ` Simon Horman [this message]
2011-10-16 23:50 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012224238.GE16825@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox