From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-shmobile: sh7372 A3SP no_suspend_console fix
Date: Wed, 09 Nov 2011 23:56:38 +0000 [thread overview]
Message-ID: <201111100056.38608.rjw@sisk.pl> (raw)
In-Reply-To: <20110712082459.18930.51005.sendpatchset@t400s>
On Wednesday, November 09, 2011, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> If "no_suspend_irq" is used on the sh7372 Mackerel board
> with v3.2-rc1 then Suspend-to-RAM fails because the serial
> console tries to write to the SCIF driver even though the
> power domain is turned off.
>
> This patch checks the state of "console_suspend_enabled"
> to see if A3SP should be forced enabled.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
Applied to linux-pm/pm-fixes.
Thanks,
Rafael
> ---
>
> arch/arm/mach-shmobile/pm-sh7372.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- 0001/arch/arm/mach-shmobile/pm-sh7372.c
> +++ work/arch/arm/mach-shmobile/pm-sh7372.c 2011-11-09 19:38:52.000000000 +0900
> @@ -20,6 +20,7 @@
> #include <linux/delay.h>
> #include <linux/irq.h>
> #include <linux/bitrev.h>
> +#include <linux/console.h>
> #include <asm/system.h>
> #include <asm/io.h>
> #include <asm/tlbflush.h>
> @@ -469,6 +470,11 @@ void __init sh7372_pm_init(void)
> /* do not convert A3SM, A3SP, A3SG, A4R power down into A4S */
> __raw_writel(0, PDNSEL);
>
> + /* serial consoles make use of SCIF hardware located in A3SP,
> + * keep such power domain on if "no_console_suspend" is set.
> + */
> + sh7372_a3sp.stay_on = !console_suspend_enabled;
> +
> sh7372_suspend_init();
> sh7372_cpuidle_init();
> }
>
>
prev parent reply other threads:[~2011-11-09 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 8:24 [PATCH] ARM: mach-shmobile: sh7372 A3SP prototype support V2 Magnus Damm
2011-09-27 8:47 ` [PATCH] ARM: mach-shmobile: sh7372 A3SP " Magnus Damm
2011-10-16 20:05 ` Rafael J. Wysocki
2011-11-09 11:02 ` [PATCH] ARM: mach-shmobile: sh7372 A3SP no_suspend_console fix Magnus Damm
2011-11-09 23:56 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111100056.38608.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox